ext/openssl: allow constructing a public-only RSA key#22703
Open
JanTvrdik wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenSSL extension so openssl_pkey_new() can construct an RSA public-only key from raw parameters (n and e), aligning RSA behavior with the existing public-key construction support for DSA/DH/EC and enabling clean public-key verification flows (e.g., WebAuthn/COSE RSA keys).
Changes:
- Allow RSA key construction without providing the private exponent
d, and propagate anis_privateflag into theOpenSSLAsymmetricKeywrapper. - Update the OpenSSL 1.x and 3.x backends to select public-key vs keypair construction appropriately.
- Add a PHPT test covering reconstruction from
n/eand verifying/encrypting with the resulting key; document the change inUPGRADING.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADING | Documents the new RSA public-only construction behavior for openssl_pkey_new(). |
| ext/openssl/tests/openssl_pkey_new_rsa_public.phpt | Adds regression coverage for constructing an RSA public key from n/e and using it in verify/encrypt flows. |
| ext/openssl/php_openssl_backend.h | Updates the RSA init function signature to return an is_private out-param. |
| ext/openssl/openssl.c | Uses the new is_private out-param when wrapping RSA keys from openssl_pkey_new(). |
| ext/openssl/openssl_backend_v3.c | Implements RSA public-only creation via OpenSSL 3 fromdata() selection (PUBLIC_KEY vs KEYPAIR). |
| ext/openssl/openssl_backend_v1.c | Implements RSA public-only creation in the legacy backend and threads is_private through the init path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #22702