Sync return type changes

[kocsismate]

No description provided.

[ndossche]

Looks mostly right

[Girgias]

It seems the image functions returned E_WARNING + false in PHP 7 but those got converted to ValueErrors in PHP 8

[kocsismate]

It seems the image functions returned E_WARNING + false in PHP 7 but those got converted to ValueErrors in PHP 8

@Girgias Do you have a suggestion how I should document this?

[Girgias]

It seems the image functions returned E_WARNING + false in PHP 7 but those got converted to ValueErrors in PHP 8

@Girgias Do you have a suggestion how I should document this?

I guess the usual way we do it, add an XML entity for the 8.0 changelog entry and maybe an XML entity for the paragraph to add to the new error/exceptions sections?

[kocsismate]

@Girgias I am currently trying to address your review comment, but I noticed that the warnings + false return was related to the resource to object conversion, right? And afterwards Nikita corrected a bunch of misleading RETURN_FALSE calls: php/php-src@429378d#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283R796

That said, I'm wondering if we have ever documented such changes? Usually only the parameter/return type change is documented in the changelog as far as I can remember. In case of ext/gd, the changelog already contains the following:

"image expects a GdImage
instance now; previously, a valid gd resource was expected."

So I'm wondering if the changelog about the return type change as well as the error section is really a must-have?

[Girgias]

Oh false was only ever returned for ZPP failures? Yeah, then I don't think we need to document it as it's part of the old UB disclaimer.

[kocsismate]

Yes, these function only ever returned false because of zend_fetch_resource(). If you have a look at php/php-src@8aad466#diff-00d1efef2247b288c86a6c3bfefac111a4774fbc5453fdc02dcf36c4a23da283L61 for example, you'll see that there was no other path which used to return false for imagefill().