Repository navigation
fix: handle notifications and batches for invalid sessions in Protocol - #88
Open
TomHAnderson wants to merge 1 commit into
Open
TomHAnderson wants to merge 1 commit into
TomHAnderson wants to merge 1 commit into
Conversation
processMessage() read $message->id when the session was not found, which crashed with "Undefined property" for notifications (e.g. a client sending notifications/initialized with a stale Mcp-Session-Id). Notifications are now logged and ignored, and requests/batches use getId() for the error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processMessage() read $message->id when the session was not found, which crashed with "Undefined property" for notifications (e.g. a client sending notifications/initialized with a stale Mcp-Session-Id). Notifications are now logged and ignored, and requests/batches use getId() for the error.
Fixes #84
Tests: I added two regression tests to ProtocolTest.php: one for a notification on an unknown session and one for a batch. All 30 tests in ProtocolTest pass.
Full suite: inside the sandbox, the HTTP integration tests can't connect to their local test servers. Outside the sandbox, they still failed on every run: 11 to 30 failures, with different tests failing each time.
Development notes:
composer lint on PHP 8.5.5 results in
Fixed 26 of 121 files in 1.058 seconds, 192.00 MB memory used
lint fixes not committed