Add additional Universal sniffs to ruleset#54
Merged
dereuromark merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
Adopt PHPCSExtra Universal sniffs that are not yet covered: - Universal.CodeAnalysis.NoEchoSprintf - Universal.CodeAnalysis.ConstructorDestructorReturn - Universal.CodeAnalysis.ForeachUniqueAssignment - Universal.CodeAnalysis.StaticInFinalClass - Universal.Operators.TypeSeparatorSpacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts five PHPCSExtra Universal sniffs that are not yet covered by our ruleset (nor by any existing Slevomat/Generic/PSR rule we currently reference):
Universal.CodeAnalysis.NoEchoSprintf— recommends `printf()` over `echo sprintf()`Universal.CodeAnalysis.ConstructorDestructorReturn— disallows return types / discourages return values in constructors/destructorsUniversal.CodeAnalysis.ForeachUniqueAssignment— detects foreach loops using identical variables for key and valueUniversal.CodeAnalysis.StaticInFinalClass— flags unnecessary `static` in final classesRelated to #53.
`composer cs-check`, `composer test`, and `composer stan` all pass locally.