Generate ALTER TABLE SET UNLOGGED/LOGGED when persistence is changed (#9677)#9768
Draft
pavanmanishd wants to merge 2 commits intopgadmin-org:masterfrom
Draft
Generate ALTER TABLE SET UNLOGGED/LOGGED when persistence is changed (#9677)#9768pavanmanishd wants to merge 2 commits intopgadmin-org:masterfrom
pavanmanishd wants to merge 2 commits intopgadmin-org:masterfrom
Conversation
Add onMouseDown handler to the tab close button that fires layoutDocker.close() when mouse button 1 (middle click) is pressed. preventDefault() stops the browser's auto-scroll cursor from appearing. This matches the standard UX in Chrome, Firefox, and VS Code where middle-click on a tab closes it.
…istence changes The Unlogged toggle in Table Properties was read-only — toggling it and saving did not generate any DDL. Both the default/ and 11_plus/ update.sql templates were missing the relpersistence alter block. Add the missing section to both templates: ALTER TABLE ... SET UNLOGGED; (when relpersistence toggled on) ALTER TABLE ... SET LOGGED; (when relpersistence toggled off) The relpersistence value is already fetched by properties.sql and tracked in the form; this change wires it through to the DDL generation.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9677
Problem
The Unlogged toggle in Table Properties → Advanced has no effect. Toggling it and saving produces no DDL — the
relpersistencechange was tracked in the form but never written to the update SQL templates.Fix
Add the missing block to both
default/update.sqland11_plus/update.sql:{% if data.relpersistence is defined and data.relpersistence != o_data.relpersistence %} ALTER TABLE IF EXISTS ... SET {% if data.relpersistence %}UNLOGGED{% else %}LOGGED{% endif %}; {% endif %}The
relpersistencefield is already fetched byproperties.sql(relpersistence = 'u'→ true) and tracked in the form; this change wires it through to DDL generation.