Clarify where the LLM API key files should be. #9758#9760
Clarify where the LLM API key files should be. #9758#9760akshay-joshi merged 1 commit intopgadmin-org:masterfrom
Conversation
WalkthroughDocumentation and help text clarifications were expanded for AI provider API key file paths across configuration documentation and application code. The updates explain that paths are relative to the pgAdmin server filesystem, support home directory (~) expansion, and are optional when using custom URLs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/pgadmin/llm/__init__.py (1)
126-127: Keep UI help text consistent with implemented~path expansion.Consider adding one short sentence that
~expands to the pgAdmin server process user’s home directory, so the in-app help matches documented and implemented behavior.Suggested wording tweak
'This path must be on the server hosting pgAdmin, ' 'e.g. inside the container when using Docker. ' + 'The ~ prefix expands to the home directory of the ' + 'user running the pgAdmin server process. ' 'The file should contain only the API key. The API key 'Also applies to: 190-191
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/pgadmin/llm/__init__.py` around lines 126 - 127, The UI help text strings in web/pgadmin/llm/__init__.py that warn "This path must be on the server hosting pgAdmin..." need a short追加 sentence stating that "~" expands to the pgAdmin server process user's home directory so the in-app help matches implemented behavior; locate the two occurrences of that help text in the module and append a concise sentence like '"Note: "~" expands to the pgAdmin server process user’s home directory."' to each string.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@web/pgadmin/llm/__init__.py`:
- Around line 126-127: The UI help text strings in web/pgadmin/llm/__init__.py
that warn "This path must be on the server hosting pgAdmin..." need a short追加
sentence stating that "~" expands to the pgAdmin server process user's home
directory so the in-app help matches implemented behavior; locate the two
occurrences of that help text in the module and append a concise sentence like
'"Note: "~" expands to the pgAdmin server process user’s home directory."' to
each string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d2d48fc1-fe6a-4708-b233-3419dc6d966b
📒 Files selected for processing (3)
docs/en_US/ai_tools.rstdocs/en_US/preferences.rstweb/pgadmin/llm/__init__.py
#9758
Summary by CodeRabbit