Improve error message for array comparison in Should -Be#2699
Open
yezhi0 wants to merge 2 commits into
Open
Conversation
Show collection length and type when array comparison fails due to different lengths or types, addressing confusing error messages where both sides appeared identical. Related: pester#1154
nohwnd
reviewed
Jun 11, 2026
nohwnd
left a comment
nohwnd
left a comment
Member
There was a problem hiding this comment.
provide tests for the change you are making
| # This looks odd; it's to unroll single-element arrays so the "-is [string]" expression works properly. | ||
| $ActualValue = $($ActualValue) | ||
| $ExpectedValue = $($ExpectedValue) | ||
| # 获取类型和长度信息 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error message when
Should -Becompares two arrays that differ in length or type, but appear identical due to unrolling.Changes:
Fixes #1154