Better TypeScript types for viewer-datagrid
#3116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
datagrid-types
branch
from
2df90bc to
1e1f81b
Compare
sinistersnare
approved these changes
Feb 4, 2026
Contributor
sinistersnare
left a comment
sinistersnare
left a comment
There was a problem hiding this comment.
LGTM wrote some nits out but they are very minor.
| RegularTable, | ||
| DatagridModel, | ||
| PerspectiveViewerElement, | ||
| import { CellMetadataBody } from "regular-table/dist/esm/types.js"; |
Contributor
There was a problem hiding this comment.
It would be great if this was exported at the top level of regular-table instead of needing to reach into its dist/ dir
Comment on lines
-225
to
+218
| get_psp_type, | ||
| // get_psp_type, |
| // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | ||
|
|
||
| import { CellMetadata } from "regular-table/dist/esm/types.js"; | ||
| import { CellMetadataBody } from "regular-table/dist/esm/types.js"; |
Contributor
There was a problem hiding this comment.
Same nit here with the import (as elsewhere in the code that uses these type imports
|
|
||
| const [hex, r, g, b] = colorRecord; | ||
|
|
||
| // @ts-ignore |
Contributor
There was a problem hiding this comment.
This pattern is used elsewhere, maybe we shoul dkeep the WithFlags bit
Member
Author
There was a problem hiding this comment.
TypeScript can't extend union types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
viewer-datagridto use new TypeScript types exporte din[email protected], and fixes a flapping test.