feat: reuse list view controls in query preset editor#17023
Open
PatrikKozak wants to merge 7 commits into
Open
feat: reuse list view controls in query preset editor#17023PatrikKozak wants to merge 7 commits into
PatrikKozak wants to merge 7 commits into
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the Query Presets edit drawer to drive its group-by, columns, and filter inputs with the list view's own
GroupByControl,ColumnsButton, andWhereBuilder, so editing a preset uses the exact controls it configures.Previously the drawer rendered a separate
GroupByBuilderand aPillSelector-based column picker that duplicated — and drifted from — the real list controls. Those shared controls now accept an optional form mode:GroupByControltakesvalue/onChange, andColumnSelector/ColumnsButtontakecolumns/onChange. When provided, they read and write the form state instead of list query state, leaving list view behavior untouched.GroupByBuilderis removed.The drawer layout is regrouped to match: a
presetsheading sits inline with the group-by and columns buttons via the newQueryPresetsHeadingUI field, and anaccessheading replaces the oldSharing settingsgroup label above the sharing controls.Supporting fixes that this drawer surfaced:
Popupnow detects aposition: fixedancestor (e.g. an openDrawer) and positions itself withfixed, so popups no longer drift when the background scrolls.bodyscroll-lock is reinforced in CSS, since faceless-ui's JS lock could be cleared early when a sibling modal mounts closed.WhereBuilderadds its first filter on a single click in form mode, where the committed placeholder row was previously rejected by validation.DocumentDrawerHeaderskips the meta row entirely when there is no status, timestamp, or autosave to show.Adds the
general:accessandgeneral:presetstranslation keys across all locales.