fix(ui): show dot menu when editMenuItems exist regardless of create/delete permission#16989
Open
jhjh1214 wants to merge 1 commit into
Open
fix(ui): show dot menu when editMenuItems exist regardless of create/delete permission#16989jhjh1214 wants to merge 1 commit into
jhjh1214 wants to merge 1 commit into
Conversation
…delete permission
jhjh1214
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16975
What?
editMenuItemsdefined on a collection were silently hidden when bothcreateanddeletepermissions were denied, because the three-dot menu's visibility (showDotMenu) was gated entirely on those permissions.Why?
Custom
editMenuItemsrepresent arbitrary business logic unrelated to CRUD operations. A collection that blocks creation (e.g. webhook-only) and deletion (e.g. audit trail) should still expose custom actions like "Resend confirmation email".How?
Added
EditMenuItemsas an additional condition inshowDotMenuso the popup renders whenever custom items are present, regardless of create/delete access.