Conversation
chavic
requested review from
DanGould,
benalleng and
spacebear21
as code owners
September 13, 2026 19:51
Collaborator
Coverage Report for CI Build 34783442914Coverage remained the same at 86.646%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Keep compiler diagnostics visible while selecting the native library from Cargo JSON. Cover script and weight validation, persistence failures and suspension, and receiver pending-fallback closure through the generated bindings. Document Python 3 for generation outside Nix.
chavic
force-pushed
the
chavic/kotlin-review-followup
branch
from
September 13, 2026 21:18
8b53277 to
e43e7e2
Compare
caarloshenriq
approved these changes
Sep 14, 2026
caarloshenriq
left a comment
caarloshenriq
left a comment
Contributor
There was a problem hiding this comment.
tACK e43e7e2
Ran ./gradlew test and ktlintCheck in nix develop .#kotlin, all green including the full IntegrationTests against real directory/relay/bitcoind. Checked the error variants against FFI source, all match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1869. Binding generation now preserves Rust compiler diagnostics when selecting the native library from Cargo's JSON output. Previously a compilation error lost its message and source location.
Adds 22 Kotlin tests covering script/weight validation, persistence failures, callbacks that suspend before succeeding or failing, and receiver pending-fallback closure through
closeSession(). The setup docs also list Python 3, which the generation script uses to parse Cargo output.Validated locally on Linux:
PAYJOIN_FFI_FEATURES=andcompileKotlinpassed.cargo fmt --all -- --check,./contrib/lint.sh, documentation with warnings denied,./contrib/test_local.sh,nix fmt -- --ci, andcodespellpassed.Disclosure: co-authored by Codex
Codex assisted with the code, tests, documentation, and PR description.
Pull Request Checklist