chore(primary details): Demo updates#12581
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughPrimary Detail demos reorganize toolbar placement, move data lists into drawer content bodies, add drawer sections for toolbar controls, switch selected drawers from static to inline rendering, and remove three demo navigation entries. ChangesPrimary Detail drawer layout
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx`:
- Around line 104-105: Move the ineffective alignItems prop from
ToolbarToggleGroup to the appropriate ToolbarGroup or ToolbarContent in all
three sites:
packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
lines 104-105,
packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
lines 104-105, and
packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
lines 103-104. Preserve the intended center alignment by applying it to the
component that handles alignment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6e4bc4cd-7b6e-458a-a383-8ba3242f7db5
📒 Files selected for processing (6)
packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailCardView.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailDataListInCard.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailSimpleListInCard.tsx
Closes #12544
I updated the following:
Summary by CodeRabbit