Skip to content

fix: Updated drag and drop to use the correct glass theme.#12306

Open
dlabaj wants to merge 2 commits intopatternfly:mainfrom
dlabaj:dd-updates
Open

fix: Updated drag and drop to use the correct glass theme.#12306
dlabaj wants to merge 2 commits intopatternfly:mainfrom
dlabaj:dd-updates

Conversation

@dlabaj
Copy link
Copy Markdown
Contributor

@dlabaj dlabaj commented Mar 31, 2026

Fixes #12269 by updating the styling for drag and drop.

Summary by CodeRabbit

  • Style
    • Adjusted dragging overlay background color for improved visual consistency.
    • Swapped the grip icon to a filled variant for enhanced visual presentation and clarity.

@dlabaj dlabaj requested a review from kmcfaul March 31, 2026 19:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f82958e-a9b1-4f66-84e7-e76cebbaef7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5503d97 and c1e2dc9.

⛔ Files ignored due to path filters (1)
  • packages/react-drag-drop/src/components/DragDrop/__tests__/__snapshots__/DragDrop.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-drag-drop/src/components/DragDrop/DragButton.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-drag-drop/src/components/DragDrop/DragButton.tsx

Walkthrough

Updated drag-and-drop UI assets: changed the dragging overlay CSS custom property and replaced the grip icon mapping and usage to the filled Rhodecode grip-vertical asset. No API, props, or control flow changes.

Changes

Cohort / File(s) Summary
Drag & Drop — container
packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx
Changed dragging overlay background CSS custom property from var(--pf-t--global--background--color--primary--default) to var(--pf-t--global--background--color--floating--default).
Drag & Drop — button
packages/react-drag-drop/src/components/DragDrop/DragButton.tsx
Replaced rendered icon: previously used GripVerticalIcon, now renders RhUiGripVerticalFillIcon (import/render change only).
Icon mapping
packages/react-icons/scripts/icons/pfToRhIcons.mjs
Updated pfToRhIcons.GripVerticalIcon mapping: name and icon lookup changed from rh-ui-grip-verticalrh-ui-grip-vertical-fill.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • thatblindgeye
  • nicolethoen
  • kmcfaul
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes in the pull request, which involve updating drag and drop styling to use the correct CSS custom property for the glass theme.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 31, 2026

FolderOpenIcon: { name: 'rh-ui-folder-open', icon: getIconData('rh-ui-folder-open') },
GripHorizontalIcon: { name: 'rh-ui-grip-horizontal', icon: getIconData('rh-ui-grip-horizontal') },
GripVerticalIcon: { name: 'rh-ui-grip-vertical', icon: getIconData('rh-ui-grip-vertical') },
GripVerticalIcon: { name: 'rh-ui-grip-vertical-fill', icon: getIconData('rh-ui-grip-vertical-fill') },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the drag icon used in DragButton to the new RhUiGripVerticalFillIcon directly? We can still keep this update for product team migration.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like the PR needs a snapshot update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants