-
Notifications
You must be signed in to change notification settings - Fork 147
Add accented card design guidelines #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lboehling
wants to merge
1
commit into
patternfly:main
Choose a base branch
from
lboehling:add-accented-card-design-guidelines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,8 +101,30 @@ The header element can be made expandable in situations where you want to hide t | |
| <div class="ws-docs-content-img"> | ||
|  | ||
| </div> | ||
|
|
||
|
|
||
|
|
||
| ### Accented cards | ||
|
|
||
| Use an accented card to give one or more cards more visual prominence in a set. An accented card includes a short brand accent mark centered along the top edge. The mark uses the brand accent color and is meant for hierarchy and emphasis, not to communicate status. | ||
|
|
||
| <div class="ws-docs-content-img"> | ||
|  | ||
| </div> | ||
|
|
||
| Add the accent to a single card or a small number of cards in a row to help users identify a featured, recommended, or primary option among similar cards. For example, you might accent one plan in a pricing comparison or one entry point in a catalog view. | ||
|
|
||
| Do not use the accent mark to indicate status. On cards that include status information, such as success, warning, or danger, use status indicators like icons, labels, or semantic colors instead. Avoid combining an accented card with status-specific color treatments that could be confused with the accent mark. | ||
|
|
||
| #### When to use | ||
|
|
||
| - You want to highlight one or a few cards as featured, recommended, or primary among similar options. | ||
| - The accent supports a clear visual hierarchy without relying on status color. | ||
|
|
||
| #### When not to use | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything looks good to me! completely optional, but we could add an image visual that shows "do not do" or when not to use examples to double down. |
||
|
|
||
| - The card needs to communicate status. Use status indicators instead. | ||
| - You plan to accent most or all cards in a set. The accent loses meaning when overused. | ||
| - The card has no hierarchy purpose. Do not add the accent for decoration alone. | ||
|
|
||
| ### Selectable cards | ||
| Selectable cards have a checkbox or radio button to indicate that a card is selectable. To select a card, users can click anywhere on the card. PatternFly supports two types of selectable cards: | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit thing: would we want to say something more like "icons or labels, with either optionally paired with semantic colors"? Just worried if the way it's worded now if consumers would take it as "I can just use color for status" or something, but that might just be me overthinking