fix: preserve multichar short option in unknown-option errors#3254
Closed
klouds27 wants to merge 3 commits intopallets:mainfrom
Closed
fix: preserve multichar short option in unknown-option errors#3254klouds27 wants to merge 3 commits intopallets:mainfrom
klouds27 wants to merge 3 commits intopallets:mainfrom
Conversation
When a multichar option like -dbg is defined, passing -dbgwrong previously reported 'No such option: -d' due to short-option fallback. Preserve the longest known option prefix so the error reports 'No such option: -dbg' instead. Adds a regression test for this case. Closes pallets#2779 Signed-off-by: klouds27 <adalwolfad@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2779
when a multichar option like -dbg is defined, passing -dbgwrong previously reported no such option: -d due to short-option fallback.
this change preserves the longest known option prefix so the error reports no such option: -dbg instead.
it also adds a regression test for this case and includes a changelog entry in CHANGES.rst.