Skip to content

Switch to prettyplease formater - #1402

Open
rpolishchuk wants to merge 1 commit into
oxidecomputer:mainfrom
rpolishchuk:switch-to-prettyplease
Open

Switch to prettyplease formater#1402
rpolishchuk wants to merge 1 commit into
oxidecomputer:mainfrom
rpolishchuk:switch-to-prettyplease

Conversation

@rpolishchuk

Copy link
Copy Markdown

Not everyone is living on the edge (see #843) :)

This commit switches to prettyplease (noted as an option in #843 (comment)) fix test failures with the stable toolchain similar to:

called `Result::unwrap()` on an `Err` value: Unstable("wrap_comments, normalize_doc_attributes, format_strings")

Also split_multiline_doc_attributes preprocess comments to avoid switch from /// to /** */

@rpolishchuk
rpolishchuk marked this pull request as ready for review July 25, 2026 22:52
@ahl

ahl commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

I'm not sure that this is the right approach for cargo-progenitor in particular. It emits a stand-alone crate--I think there's a reasonable expectation for that crate to be rustfmt compliant. I do love prettyplease, but its output isn't the same (as evidenced by the 45k lines of change in this PR.

@ahl

ahl commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Happy to discuss this, but if I don't hear from you, I'll close this next week; we can always re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants