Conversation
3339374 to
809857b
Compare
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/spaces/members/SearchMembersAdapter.kt
Outdated
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersActivity.kt
Outdated
Show resolved
Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersAdapter.kt
Show resolved
Hide resolved
...va/com/owncloud/android/data/members/datasources/implementation/OCRemoteMembersDataSource.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/members/repository/OCMembersRepository.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/test/java/com/owncloud/android/data/members/OCRemoteMembersDataSourceTest.kt
Outdated
Show resolved
Hide resolved
...om/owncloud/android/data/members/datasources/implementation/OCRemoteMembersDataSourceTest.kt
Show resolved
Hide resolved
owncloudData/src/test/java/com/owncloud/android/data/members/OCRemoteMembersDataSourceTest.kt
Outdated
Show resolved
Hide resolved
4c1b022 to
c3afb33
Compare
jesmrec
left a comment
There was a problem hiding this comment.
CR approved, let's QA this
(1) [FIXED]Typing characters does not refresh screen with results. App should be unfocused and focused to list: Screenrecorder-2026-01-21-13-31-54-142.mp4NOTE: not in every server... crazy Xiaomi Redmi Note 13, Android 15
|
(2) [FIXED]In search view, add some special characters like Current: Snackbar I realised the query parameter is Expected: No error, just no results in case there are no matches. Checking iOS, the query parameter is enclosed in quotation marks (if it helps):
Xiaomi Redmi Note 13, Android 15
|
(3) [FIXED]In case the typed chars don't match with any user, it'd be a good idea to show a message like Xiaomi Redmi Note 13, Android 15
|
|
I think that (1) and (2) are fixed now @jesmrec 🙌🏻 |
(4) (improvement) [FIXED]Given a high number of results, the lag for showing the results is perceptible. Could it be posible to add a spinner, so the view does not seem to be frozen. Ideally (it might not be feasible), the spinner would replace the ✖️ while the operation is executed. Xiaomi Redmi Note 13, Android 15
|
|
(2) fixed |
(5) [FIXED]Coming from #4754 (comment) The idea should be prevent effects like this one: Screenrecorder-2026-01-22-09-22-26-372.mp4user types quick and the results appear later. Final status is correct ✅ , but, if only last character is taken in account, lag could be reduced Xiaomi Redmi Note 13, Android 15
|
(6) [WONT FIX]About keyboard navigation: the EDIT: it can be reached but the focused Screenrecorder-2026-01-22-10-46-29-837.mp4Need to check if the focus color could be changed Xiaomi Redmi Note 13, Android 15
|
47b442e to
2f6ccce
Compare
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Show resolved
Hide resolved
2f6ccce to
d12d832
Compare
|
(3) and (4) should be fixed 🤔 |
|
(3) and (4) fixed |
...dApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersViewModel.kt
Outdated
Show resolved
Hide resolved
a0f13c6 to
76a2cac
Compare
(7) [FIXED]
Current: spinner and Expected: if user is waiting for results (spinner), results from previous requests should be cleaned Xiaomi Redmi Note 13, Android 15
|
76a2cac to
7e4bbbe
Compare
|
(5) and (7) fixed, good performance in searching 💯 |
76fa41f to
35ca2db
Compare
|
(1) fixed |
|
Approved on my side, show must go on!! 🤘 🤘 |
35ca2db to
7e9d118
Compare
Related Issues
App: #4613
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Add%20member.md
Reports:
Unknown errorwhen special characters [FEATURE REQUEST] Add a member to a space: Search user and show the list of matches #4754 (comment) [FIXED]+for adding members [FEATURE REQUEST] Add a member to a space: Search user and show the list of matches #4754 (comment) [WONT FIX]