[AI-FSSDK] [FSSDK-12750] Use attribute id instead of key for CMAB prediction requests#402
Merged
esrakartalOpt merged 2 commits intoJul 2, 2026
Conversation
esrakartalOpt
approved these changes
Jul 2, 2026
…ai/raju-opti/FSSDK-12750-cmab-attribute-id-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CMAB service's
filter_attributesmethod was using the attribute's key as the map key when building the filtered attributes hash for CMAB prediction requests. The CMAB prediction endpoint expects the attribute's id in the"id"field of the JSON payload, not the key. This change updates the method to use the attribute id as the hash key so the downstream HTTP request sends the correct identifier.Changes
filter_attributesinCmabServiceto useattribute_idinstead ofattribute_keyas the hash key for filtered attributesattributeIdsis nil or non-ArrayJira Ticket
FSSDK-12750