Open
Conversation
Member
|
This should probably implemented using existing API:
class ResultSet implements \IteratorAggregate {
// Rest of the class ...
public function getIterator(): \Generator
{
const statement = $this->statement;
try {
while (false !== ($row = $statement->fetch())) {
yield $row;
}
} finally {
$statement->closeCursor();
}
}
}And can be directly used by foreach: $result = $db->from('users')
->select(['name', 'email'])
->fetchAssoc();
foreach ($result as $user) {
echo $user['name'], $user['email'], "\n";
} |
Author
|
Hey @sorinsarca, hope you're doing well That would make every result set iterate over a lazy source. Which would not be the optimal in some cases (where people invoke fetchAll, for instance). Making it a separate method gives the user the control over the component so it is used only when it's needed. |
Member
|
no, by implementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method creates a generator that will fetch one row at a time from the data set.
This aims to reduce memory load during ResultSet interation while maintaining the simplicity of "fetchAll" when using it inside a loop.
Here is an example:
Hope you find it useful