fix: use gh release upload instead of softprops/action-gh-release

[tmshort]

softprops/action-gh-release@v3 has deduplication logic that picks the wrong draft release when multiple drafts exist for the same tag (e.g. when a tag is moved). This caused crds.yaml, olm.yaml, and install.sh to be uploaded to a stale draft from a prior failed run rather than the current GoReleaser-created release, as seen in v0.43.0.

Replace it with 'gh release upload', which uploads directly to the release associated with the tag without creating any new release objects. --clobber makes reruns safe.

Assisted-by: Claude

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Bug fixes are accompanied by regression test(s)
• e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
• tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
• Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky and have an issue
• Code is properly formatted

[Copilot]

Pull request overview

This PR updates the release workflow to avoid incorrect artifact uploads when multiple draft releases exist for the same tag (e.g., after a tag move). It replaces softprops/action-gh-release@v3 with gh release upload so assets are uploaded directly to the release associated with the tag, with --clobber enabling safe reruns.

Changes:

• Replace softprops/action-gh-release@v3 with gh release upload for uploading rendered quickstart manifests.
• Add --clobber to make uploads idempotent across reruns.
• Authenticate GitHub CLI via GH_TOKEN using the workflow github.token.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

Since this PR includes a pivot away from the action, it kinda answers my earlier question about whether we should open an issue for softprops/action-gh-release@v3 (or PR it) to correct the behavior. I wonder if others are impacted by it.

Edit: looks like others experience the bug too... softprops/action-gh-release#772