🐛 fix: missing olm.operatorNamespace annotation#2803
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR restores OLMv0 interoperability by ensuring generated CSV-based Deployment pod templates include the olm.operatorNamespace annotation (alongside the existing olm.targetNamespaces) so operators relying on those annotations behave correctly under OLMv1.
Changes:
- Set
olm.operatorNamespaceon generatedDeployment.spec.template.metadata.annotationsfromrender.Options.InstallNamespace. - Update unit tests to assert the new annotation is present in generated deployment templates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/operator-controller/rukpak/render/registryv1/generators/generators.go | Adds olm.operatorNamespace to generated CSV deployment pod-template annotations (OLMv0 parity). |
| internal/operator-controller/rukpak/render/registryv1/generators/generators_test.go | Updates expected deployment-template annotations to include olm.operatorNamespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
723c986 to
1dd8c9c
Compare
|
Fixed the regression tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7461774
into
operator-framework:main
Description
OLMv0 sets the
olm.*annotations from OperatorGroup on thespec.template.metadata.annotationsection of the operatorDeployment. To maintain interoperability OLM v1 does do the same forolm.targetNamespacesannotation - but does NOT do it forolm.operatorNamespace. There are opeators that rely on this (see linked issue)Fixes: #2802
Reviewer Checklist