make grades page show true problem number#2912
make grades page show true problem number#2912Alex-Jordan wants to merge 1 commit intoopenwebwork:developfrom
Conversation
|
This definitely should not do this for tests. Note that in tests the problems are ALWAYS displayed for the student in consecutive order in the actual test regardless of the |
|
My wording was not concise, so I want to clarify further. If the problem ids are 1, 3, 4 in the set definition, then in the test the problem numbers are shown as 1, 2, 3. They are displayed not only consecutively, but incrementally starting from 1. The point is that the current numbering on the grades page is already consistent with the numbering that is shown for students in the test itself. |
| # For other sets we just get the largest problem ID. | ||
| $max_problem_id = max($db->listGlobalProblems($setID)); |
There was a problem hiding this comment.
There is going to need to be a special case for tests that does what the previous else case did for those. For example, if a test has numbers 1, 3, 5, then this will get 5 for the largest problem id. However, the problems will be displayed under numbers 1, 2, and 3 (on both the grades page and in the test). So this may add extra problem numbers that are shown even though there may not be any sets with those problem numbers.
|
After I posted this last night, I realized there is a (rare) use case where
this will become awkward. We assign problem sets from orcca using numbering
that matches the textbook numbering. For example, a set might use numbers
2, 12, 22, 47, 88. Do I really want 88 columns?
So now I'm thinking either to identify the actual column numbers to use
(which could still lead to a very wide table) or an alternative where it's
more clear the number in the top row is not necessarily the problem's ID
number.
Alex Jordan
Mathematics Instructor
Portland Community College
…On Tue, Feb 17, 2026, 5:35 AM Glenn Rice ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/WeBWorK/ContentGenerator/Grades.pm
<https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*discussion_r2817073310__;Iw!!Ka_JY85zDv0FFw!nVKSY5KzwRbgLpIAKdPbyzT8ECJIKZbnT6dDAy3jjO-50M0tP3U5ekFIBE6KHnPCoITzjB_4-0bNxkVW3eg1ZQ8bjOs$>
:
> + # For other sets we just get the largest problem ID.
+ $max_problem_id = max($db->listGlobalProblems($setID));
There is going to need to be a special case for tests that does what the
previous else case did for those. For example, if a test has numbers 1, 3,
5, then this will get 5 for the largest problem id. However, the problems
will be displayed under numbers 1, 2, and 3 (on both the grades page and in
the test). So this may add extra problem numbers that are shown even though
there may not be any sets with those problem numbers.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*pullrequestreview-3813992937__;Iw!!Ka_JY85zDv0FFw!nVKSY5KzwRbgLpIAKdPbyzT8ECJIKZbnT6dDAy3jjO-50M0tP3U5ekFIBE6KHnPCoITzjB_4-0bNxkVW3eg1c3neQCs$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOACXEVZV2RH43SBAIUT4MMKI5AVCNFSM6AAAAACVLVXUCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJTHE4TEOJTG4__;!!Ka_JY85zDv0FFw!nVKSY5KzwRbgLpIAKdPbyzT8ECJIKZbnT6dDAy3jjO-50M0tP3U5ekFIBE6KHnPCoITzjB_4-0bNxkVW3eg1uzjWezQ$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm changing this so that the top row will only use problem labels that are actually used. For example, if all sets in the course have had the 3rd problem cut, then the numbering at the top row will be 1, 2, 4, ... Is there any concern with that? |
|
Sounds appropriate. Although with your setup of using text book numbering, it seems that might not help if the numbers happen to vary widely between sets. |
|
Yeah, I'm prepared for that. It won't be quite as bad as I made it sound. The assigned problems are always even numbered, and there are at most 120 problems from any given section. So I think it may come to something less than 50 numbers in use. |
|
@Alex-Jordan We did talk a bit about this page could use a full overhaul, would there be a better way to present things? Is a table really appropriate for sets that have different number of problems, there are lots of empty cells. Also how accessible is one of these cells, is So if you have any ideas on how to restructure the page to be more useful for students, that might be worthwhile vs trying to tweak the existing layout. |
|
Yeah, I am not opposed to something larger scale. But I have very little
bandwidth for something comprehensive. Do any others think they would be
giving a go at an overhaul?
For a student in D2L at the grades page, they see grade items as blocks
stacked vertically, almost certainly needing to scroll down a lot to see
all items. Within each block there are some details about the grade item.
Would we want a layout like that?
Alex Jordan
Mathematics Instructor
Portland Community College
…On Tue, Feb 17, 2026, 5:24 PM Jaimos Skriletz ***@***.***> wrote:
*somiaj* left a comment (openwebwork/webwork2#2912)
<https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>
@Alex-Jordan
<https://urldefense.com/v3/__https://github.com/Alex-Jordan__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPKWb4dRk$>
We did talk a bit about this page could use a full overhaul, would there be
a better way to present things? Is a table really appropriate for sets that
have different number of problems, there are lots of empty cells. Also how
accessible is one of these cells, is <span
class="name">attempts</span><br>grade going to make much sense in its
current output to a screen reader. Is it really that useful to have
attempts on a grade page for a student? Might be useful for the student
progress page for instructors to see how many attempts students are taking,
but maybe the grades page for students shouldn't include attempts, only
grade.
So if you have any ideas on how to restructure the page to be more useful
for students, that might be worthwhile vs trying to tweak the existing
layout.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOAG7MFFALV6CQCW5D534MO5MDAVCNFSM6AAAAACVLVXUCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJXHE2DQOJWGU__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPOjGxShk$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
What I really want that started this. I want it to be easy for a student to
be surveying their grades, and see that (for example) question 7 on
assignment 5 was never completed, and they can get their in one click.
Alex Jordan
Mathematics Instructor
Portland Community College
…On Tue, Feb 17, 2026, 7:09 PM Alex Jordan ***@***.***> wrote:
Yeah, I am not opposed to something larger scale. But I have very little
bandwidth for something comprehensive. Do any others think they would be
giving a go at an overhaul?
For a student in D2L at the grades page, they see grade items as blocks
stacked vertically, almost certainly needing to scroll down a lot to see
all items. Within each block there are some details about the grade item.
Would we want a layout like that?
Alex Jordan
Mathematics Instructor
Portland Community College
On Tue, Feb 17, 2026, 5:24 PM Jaimos Skriletz ***@***.***>
wrote:
> *somiaj* left a comment (openwebwork/webwork2#2912)
> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>
>
> @Alex-Jordan
> <https://urldefense.com/v3/__https://github.com/Alex-Jordan__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPKWb4dRk$>
> We did talk a bit about this page could use a full overhaul, would there be
> a better way to present things? Is a table really appropriate for sets that
> have different number of problems, there are lots of empty cells. Also how
> accessible is one of these cells, is <span
> class="name">attempts</span><br>grade going to make much sense in its
> current output to a screen reader. Is it really that useful to have
> attempts on a grade page for a student? Might be useful for the student
> progress page for instructors to see how many attempts students are taking,
> but maybe the grades page for students shouldn't include attempts, only
> grade.
>
> So if you have any ideas on how to restructure the page to be more useful
> for students, that might be worthwhile vs trying to tweak the existing
> layout.
>
> —
> Reply to this email directly, view it on GitHub
> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>,
> or unsubscribe
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOAG7MFFALV6CQCW5D534MO5MDAVCNFSM6AAAAACVLVXUCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJXHE2DQOJWGU__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPOjGxShk$>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
get there ....
Alex Jordan
Mathematics Instructor
Portland Community College
…On Tue, Feb 17, 2026, 7:10 PM Alex Jordan ***@***.***> wrote:
What I really want that started this. I want it to be easy for a student
to be surveying their grades, and see that (for example) question 7 on
assignment 5 was never completed, and they can get their in one click.
Alex Jordan
Mathematics Instructor
Portland Community College
On Tue, Feb 17, 2026, 7:09 PM Alex Jordan ***@***.***> wrote:
> Yeah, I am not opposed to something larger scale. But I have very little
> bandwidth for something comprehensive. Do any others think they would be
> giving a go at an overhaul?
>
> For a student in D2L at the grades page, they see grade items as blocks
> stacked vertically, almost certainly needing to scroll down a lot to see
> all items. Within each block there are some details about the grade item.
> Would we want a layout like that?
>
> Alex Jordan
> Mathematics Instructor
> Portland Community College
>
> On Tue, Feb 17, 2026, 5:24 PM Jaimos Skriletz ***@***.***>
> wrote:
>
>> *somiaj* left a comment (openwebwork/webwork2#2912)
>> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>
>>
>> @Alex-Jordan
>> <https://urldefense.com/v3/__https://github.com/Alex-Jordan__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPKWb4dRk$>
>> We did talk a bit about this page could use a full overhaul, would there be
>> a better way to present things? Is a table really appropriate for sets that
>> have different number of problems, there are lots of empty cells. Also how
>> accessible is one of these cells, is <span
>> class="name">attempts</span><br>grade going to make much sense in its
>> current output to a screen reader. Is it really that useful to have
>> attempts on a grade page for a student? Might be useful for the student
>> progress page for instructors to see how many attempts students are taking,
>> but maybe the grades page for students shouldn't include attempts, only
>> grade.
>>
>> So if you have any ideas on how to restructure the page to be more
>> useful for students, that might be worthwhile vs trying to tweak the
>> existing layout.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2912*issuecomment-3917948965__;Iw!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtP2IHJixc$>,
>> or unsubscribe
>> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOAG7MFFALV6CQCW5D534MO5MDAVCNFSM6AAAAACVLVXUCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJXHE2DQOJWGU__;!!Ka_JY85zDv0FFw!nZPd437VGzredjsozqjpUWDxZdxbbu5VaJWVdFQevY1Rc1CH-lZFQ5E-9ndvZ2-iRB17zIaxSYaIFXZ-nqtPOjGxShk$>
>> .
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
|
|
@Alex-Jordan One of the ideas that came up was remove the grades page from students. The info you want is already on the ProblemSet page, but not in one place. Also the grade page is kinda ordered poorly for this. so one though, was just put the percent grade on the main Assignments page, then students can see the % of what is currently open or in the reduced scoring period, and if it isn't 100%, they can click on it and then see exactly which problems they have left to finish. |
Current brainstorm: could we add the ability to filter/sort the homepage based on incomplete assignments? I'm envisioning that the student clicks something and only assignments where they can still receive credit are shown, or are percolated to the top. A variation of this would be to add another category on the homepage for "Completed Assignments", which would contain any sets where for every question the student has either achieved the maximum available credit (taking into account reduced scoring) or has used all of their attempts. This way the only things showing in "Open Assignments" would be things where they can still improve their grade. |
|
What about assignments that are closed, but the student could use an achievement item to reopen or award credit? |
|
My initial reaction to putting the grades on the assignments page is concern about privacy. Whatever the design might end up there, I'd want to look for a way where the student has to actively click something to reveal grades. So they aren't just showing by default when the student is in a computer lab or something like that. |
This would be consistent with the current layout. Students can apply achievement items to sets in the "Past Due Assignments" section to move them back to "Open Assignments". |
|
Grades are also shown on the ProblemSet page, and the current problem they are working on, so though I agree with your privacy concern remark, what makes the assignments page special in this regard, when grades are shown in plain view elsewhere. I had a few more thoughts, though first the reason we thought about just putting the grade info on the assignments page, is as we thought about how to arrange/display things on the grade page, lots of thoughts would be a similar layout as to what is on the assignments page plus adding grades. So if the grade page looks almost identical to the assignments page with grades added, the idea of is it worth having two pages came up. I too thought about the idea of making adding a 'complete' / 'incomplete' message to assignments based on if their grade is the maximum it can be or if they are out of attempts. I might have time in a few weeks to work on something, but the next two weeks I'm fairly swamped. |
|
Here is a very rough workup of what a grades page could look like. It is mostly just a rough idea, there is a lot that would need to be done. somiaj/new-grades-page |
4 participants
Suppose there is an assignment with exercises that were originally numbered 1-10. Then an instructor deleted numbers 2 and 7, and did not renumber the problems in the assignment. Prior to the change here, the grades page shows scores for "number 1" through "number 8". But of course, "number 8" is labeled "number 10" when the student visits the set, and so on.
So this change makes it so that in the Grades page, the score for "number 10" is under the 10 column, and so on. In columns 2 and 7, there will be an empty cell.
So it will be with regular sets and jitar sets. But this PR should not change anything with tests. For those, it's too complicated to try to change the current behavior because of how exercises can be presented in a random order. I'm not even sure that other things don't break if an instructor deletes an exercise from a test template or test version. If someone thinks this should happen with tests as well, I will need help making that happen.
This is a preliminary PR so that later, I can make the cells link to the problem number in question.