Fix an issue with adding and updating users when the accomodation_time_factor is not set.#2911
Open
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Open
Conversation
somiaj
approved these changes
Feb 16, 2026
drgrice1
force-pushed
the
bugfix/add-user-accomodation-time-factor
branch
2 times, most recently
from
f91e739 to
44e2c49
Compare
drgrice1
changed the title
Member
Author
|
I had to change this further. Not only the |
somiaj
approved these changes
Feb 17, 2026
dlglin
changed the title
…_factor is not set. The `gen_new` method is not sufficient to create the new method for database tables with default values for columns. So the `newUser` method needs to be created manually and make sure the default is set. This was reported in issue openwebwork#2910, and fixes that issue and most likely other places where users are added or updated without explicitly setting the `accomodation_time_factor`.
drgrice1
force-pushed
the
bugfix/add-user-accomodation-time-factor
branch
from
44e2c49 to
490e7ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gen_newmethod is not sufficient to create the new method for database tables with default values for columns. So thenewUsermethod needs to be created manually and make sure the default is set.This was reported in issue #2910, and fixes that issue and most likely other places where users are added or updated without explicitly setting the
accomodation_time_factor.