fix: disable wallet history command due to Taostats API changes (#235) #808
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Taostats API now requires an API key which cannot be bundled with btcli. Displays informative message to users until a chain-native solution is found. Fixes opentensor#235 Related to opentensor#302
Contributor
|
Thank you for your contrib! Also I would change the message up a bit to something like "This command is currently disabled as it used external APIs which are no longer feasible; meanwhile a chain native data fetching solution is being investigated" |
This command is disabled as it used external APIs which are no longer feasible; meanwhile a chain native data fetching solution is being investigated. Fixes opentensor#235 Related to opentensor#302
…ose-blockchain/btcli into fix/disable-wallet-history-235
Author
|
what about this @ibraheem-abe ?
Commit |
Contributor
|
@jose-blockchain And also please base your branch on top of latest staging - we dont merge directly to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the
wallet historycommand which is currently broken due to the Taostats API(
https://api.subquery.network/sq/TaoStats/bittensor-indexer) returning 404 errors.The API now requires an API key which cannot be feasibly bundled with btcli.
The command now displays an informative message to users explaining the situation and
linking to the tracking issue.
Changes
wallet_history()inbittensor_cli/src/commands/wallets.pyto displaya disabled message instead of attempting the broken API call
Fixes
btcli w historywith new endpoint #302Potential Reviewers
@thewhaleking @distributedstatemachine @ibraheem-abe