OCPBUGS-98323: fix proxy conformance by adding AWS_REGION_OVERWRITE to blackholenetwork step#81729
OCPBUGS-98323: fix proxy conformance by adding AWS_REGION_OVERWRITE to blackholenetwork step#81729jparrill wants to merge 1 commit into
Conversation
|
@jparrill: This pull request references Jira Issue OCPBUGS-98323, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe blackholenetwork AWS steps now support an explicit region override, and the Hypershift 4.23 and 5.0 proxy conformance jobs set it to ChangesAWS region override
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance |
|
@jparrill: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2c4f553 to
c9855e8
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance |
|
@jparrill: your |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance |
|
/jira refresh |
|
@jparrill: This pull request references Jira Issue OCPBUGS-98323, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jparrill: your |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance |
|
@jparrill: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
This is a clean up comment that is failing in this job @jparrill : Could you please fix the deprovisioning step as well in ci-operator/step-registry/ipi/deprovision/aws/blackholenetwork/ipi-deprovision-aws-blackholenetwork-commands.sh Suggested changes: To: and adding the env var to ipi-deprovision-aws-blackholenetwork-ref.yaml. |
Rehearse analysisThe rehearse job failed, but not in any step our PR touches. Breakdown:
The This PR is the first of the fixes needed to restore proxy conformance
The rehearse confirms our code change works as intended. The downstream failure is an infrastructure problem that existed before this PR and cannot be fixed from the release repo. |
…ckholenetwork step The e2e-aws-ovn-proxy-conformance periodic (4.23/5.0) has been at 0% pass rate since the cluster_profile was changed from 'hypershift' to 'hypershift-aws' (26615a3). The hypershift-aws Boskos leases are UUID-based quota slices, so LEASED_RESOURCE is a UUID instead of an AWS region. The blackholenetwork step used LEASED_RESOURCE directly as the region for CloudFormation calls, producing bogus endpoints like cloudformation.<uuid>.amazonaws.com. Add a REGION env override to the blackholenetwork step (defaulting to empty, which falls back to LEASED_RESOURCE for backwards compat) and set REGION=us-east-1 in the HyperShift proxy conformance periodics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
|
Hey @YamunadeviShanmugam addressed. |
|
@jparrill: This pull request references Jira Issue OCPBUGS-98323, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
A total of 265 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Installation is failing due to infra issues, all the changes has been addressed |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jparrill, YamunadeviShanmugam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jparrill: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/uncc @sjenning |
Summary
AWS_REGION_OVERWRITEsupport to theipi-conf-aws-blackholenetworkstep, matching the existing pattern inipi-conf-awsAWS_REGION_OVERWRITE: us-east-1in the HyperShifte2e-aws-ovn-proxy-conformanceperiodics for 4.23 and 5.0Fixes: https://issues.redhat.com/browse/OCPBUGS-98323
Root Cause
The
e2e-aws-ovn-proxy-conformanceperiodic has been at 0% pass rate since the cluster profile was changed fromhypershifttohypershift-aws(26615a37031, Jan 2026). Thehypershift-awsBoskos leases are UUID-based quota slices, soLEASED_RESOURCEis a UUID (e.g.2e146b47-6dfa-426a-a6bf-28756a23a1c3) instead of an AWS region name.Two steps in the proxy chain used
LEASED_RESOURCEas the AWS region:ipi-conf-aws-blackholenetwork:REGION="${LEASED_RESOURCE}"— CloudFormation calls fail withcloudformation.<uuid>.amazonaws.comipi-conf-aws:REGION="${AWS_REGION_OVERWRITE:-${LEASED_RESOURCE}}"— already supports override, just needs it setChanges
blackholenetwork-commands.shREGION="${LEASED_RESOURCE}"→REGION="${AWS_REGION_OVERWRITE:-${LEASED_RESOURCE}}"blackholenetwork-ref.yamlAWS_REGION_OVERWRITEenv (default empty → falls back toLEASED_RESOURCE)AWS_REGION_OVERWRITE: us-east-1for proxy conformanceAWS_REGION_OVERWRITE: us-east-1for proxy conformanceImpact on other jobs
The
blackholenetworkstep is used by 4 workflows. All non-HyperShift consumers use cluster profiles with region-based Boskos leases (openshift-org-aws,aws-mco-qe), soAWS_REGION_OVERWRITEstays empty and falls back toLEASED_RESOURCE(a real region). No behavior change for them.Test plan
make jobspasses locallyipi-conf-aws-blackholenetworkstep passes withus-east-1(confirmed in first rehearse run)/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-proxy-conformance/cc @wking @sjenning
🤖 Generated with Claude Code
Summary by CodeRabbit
AWS_REGION_OVERWRITEsupport to AWS blackholenetwork setup and teardown steps, falling back toLEASED_RESOURCEwhen unset.us-east-1, avoiding UUID lease values being interpreted as AWS regions.