Add FAR periodic job config for system-tests (Konflux)#79606
Conversation
Adds a weekly periodic E2E job that installs the fence-agents-remediation operator from Konflux FBC artifacts and runs system-tests against OCP 4.22. Pipeline: ipi-aws → medik8s-catalogsource → medik8s-operator-subscribe → make run-tests Depends on: - openshift#79373 (medik8s-catalogsource step) - openshift#79547 (medik8s-operator-subscribe step) Jira: RHWA-1022
WalkthroughThis PR adds a new Konflux CI configuration file for medik8s system tests targeting OpenShift 4.22. The configuration defines default resource requests and introduces a weekly scheduled e2e test that validates the FAR (Fence Agents Remediation) operator with the ipi-aws workflow. Changes4.22 Konflux CI Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ugreener The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml (1)
1-44:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRun
make updateand include downstream generated changes for this new CI config.This PR adds a new periodic test/job definition, which is a structural ci-operator change and should regenerate downstream artifacts.
As per coding guidelines: “After modifying CI configuration files in
ci-operator/config/, regenerate downstream artifacts by runningmake update”. Based on learnings, env-only/commands-only edits are exceptions, but this change introduces a new test/job structure.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml` around lines 1 - 44, This change adds a new periodic test "e2e-far-weekly-aws" (workflow "ipi-aws") under ci-operator config but did not regenerate downstream artifacts; run the repository's generation step (execute "make update") to regenerate downstream CI artifacts for the new test, review the produced files for the new job/test entries, add and commit those generated files alongside this CI config change, and push the updated commit so downstream configs align with the new test definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml`:
- Around line 1-44: This change adds a new periodic test "e2e-far-weekly-aws"
(workflow "ipi-aws") under ci-operator config but did not regenerate downstream
artifacts; run the repository's generation step (execute "make update") to
regenerate downstream CI artifacts for the new test, review the produced files
for the new job/test entries, add and commit those generated files alongside
this CI config change, and push the updated commit so downstream configs align
with the new test definition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4f02a31f-459a-43ae-bd0d-61b3c55aa217
📒 Files selected for processing (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
|
@ugreener: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Adds a weekly periodic E2E job (
e2e-far-weekly-aws) that installs the fence-agents-remediation operator from Konflux FBC artifacts and runs system-tests against OCP 4.22.Pipeline
ipi-awsworkflow,medik8s-awsprofile)medik8s-catalogsourcestep (Konflux mode,OCP_VERSION=422)medik8s-operator-subscribestep (OPERATORS=fence-agents-remediation)make run-testswithECO_TEST_FEATURES=far-operatorSchedule
Weekly on Sunday 04:00 UTC (
0 4 * * 0)Dependencies
This PR depends on the step-registry steps being merged first:
CI validation will fail until both dependency PRs are merged and this PR is rebased.
Test plan
Jira: RHWA-1022
Summary by CodeRabbit
This PR adds CI/CD configuration for a new weekly periodic test job in the OpenShift release infrastructure that validates the fence-agents-remediation (FAR) operator on OCP 4.22.
Changes Made
New file:
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yamlThis new configuration file defines:
e2e-far-weekly-aws): A weekly E2E test that runs every Sunday at 04:00 UTC to validate FAR operator installation and functionalitymedik8s-awscluster profile and custom base domainmake run-testswith thefar-operatortest feature flagDependencies
This PR depends on two prerequisite step registry PRs that must be merged first:
#79373:medik8s-catalogsourcestep#79547:medik8s-operator-subscribestepCI validation will fail until these dependencies are merged and the branch is rebased.
Impact
Once merged, this configuration will enable automated weekly testing of the FAR operator within the OpenShift CI infrastructure, ensuring compatibility with OCP 4.22.