Skip to content

Add FAR periodic job config for system-tests (Konflux)#79606

Open
ugreener wants to merge 1 commit into
openshift:mainfrom
ugreener:rhwa-far-periodic-konflux
Open

Add FAR periodic job config for system-tests (Konflux)#79606
ugreener wants to merge 1 commit into
openshift:mainfrom
ugreener:rhwa-far-periodic-konflux

Conversation

@ugreener
Copy link
Copy Markdown
Contributor

@ugreener ugreener commented May 21, 2026

Summary

Adds a weekly periodic E2E job (e2e-far-weekly-aws) that installs the fence-agents-remediation operator from Konflux FBC artifacts and runs system-tests against OCP 4.22.

Pipeline

  1. Provision AWS cluster (ipi-aws workflow, medik8s-aws profile)
  2. medik8s-catalogsource step (Konflux mode, OCP_VERSION=422)
  3. medik8s-operator-subscribe step (OPERATORS=fence-agents-remediation)
  4. Run tests: make run-tests with ECO_TEST_FEATURES=far-operator

Schedule

Weekly on Sunday 04:00 UTC (0 4 * * 0)

Dependencies

This PR depends on the step-registry steps being merged first:

CI validation will fail until both dependency PRs are merged and this PR is rebased.

Test plan

  • CI validation passes after dependency PRs merge and rebase
  • Periodic job appears in step registry after merge
  • First weekly run installs FAR and executes system-tests

Jira: RHWA-1022

Summary by CodeRabbit

This PR adds CI/CD configuration for a new weekly periodic test job in the OpenShift release infrastructure that validates the fence-agents-remediation (FAR) operator on OCP 4.22.

Changes Made

New file: ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

This new configuration file defines:

  • Periodic test job (e2e-far-weekly-aws): A weekly E2E test that runs every Sunday at 04:00 UTC to validate FAR operator installation and functionality
  • OCP 4.22 target: Configured to test against OpenShift 4.22 using Konflux FBC (Flexible Build Chains) artifacts
  • AWS infrastructure: Uses the AWS IPI (Installer-provisioned infrastructure) workflow with the medik8s-aws cluster profile and custom base domain
  • FAR operator testing: Installs the fence-agents-remediation operator using the Konflux pipeline and executes system tests via make run-tests with the far-operator test feature flag
  • Resource constraints: Defines default resource requests (500m CPU, 1000Mi memory) for all workloads, with specific overrides (100m CPU, 200m memory) for the test execution container

Dependencies

This PR depends on two prerequisite step registry PRs that must be merged first:

  • #79373: medik8s-catalogsource step
  • #79547: medik8s-operator-subscribe step

CI validation will fail until these dependencies are merged and the branch is rebased.

Impact

Once merged, this configuration will enable automated weekly testing of the FAR operator within the OpenShift CI infrastructure, ensuring compatibility with OCP 4.22.

Adds a weekly periodic E2E job that installs the fence-agents-remediation
operator from Konflux FBC artifacts and runs system-tests against OCP 4.22.

Pipeline: ipi-aws → medik8s-catalogsource → medik8s-operator-subscribe → make run-tests

Depends on:
- openshift#79373 (medik8s-catalogsource step)
- openshift#79547 (medik8s-operator-subscribe step)

Jira: RHWA-1022
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Walkthrough

This PR adds a new Konflux CI configuration file for medik8s system tests targeting OpenShift 4.22. The configuration defines default resource requests and introduces a weekly scheduled e2e test that validates the FAR (Fence Agents Remediation) operator with the ipi-aws workflow.

Changes

4.22 Konflux CI Configuration

Layer / File(s) Summary
CI configuration for 4.22 Konflux testing
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
New Konflux CI configuration defining the 4.22 candidate release target, default resource requests, and a weekly e2e-far-weekly-aws test workflow that uses the ipi-aws workflow with FAR operator environment variables and test execution commands.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Suggested labels

jira/valid-reference

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a FAR (fence-agents-remediation) periodic job configuration for system-tests using Konflux, which matches the changeset's addition of the e2e-far-weekly-aws configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI configuration YAML only, no Ginkgo test code. Test names (e2e-far-weekly-aws, e2e-test) are static with no dynamic content, UUIDs, timestamps, or generated suffixes.
Test Structure And Quality ✅ Passed PR adds only a YAML CI/CD configuration file, not Ginkgo test code. Custom check requires reviewing Ginkgo test quality, which is not applicable here.
Microshift Test Compatibility ✅ Passed This PR adds only a CI configuration file (YAML), not Ginkgo test code. The MicroShift compatibility check applies only to new test definitions, which are not present in this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds only a YAML CI configuration file, not actual Ginkgo e2e test code. The check is inapplicable as no new test definitions (It, Describe, Context, etc.) are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only CI/CD configuration files, no deployment manifests or operator code. No topology-aware scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR adds a YAML CI configuration file only, not executable code. OTE Binary Stdout Contract check applies to executable binaries/test code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only a CI configuration file, not Ginkgo test code. The actual test implementation is in an external medik8s/system-tests repository, outside the scope of this release PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from maximunited and slintes May 21, 2026 14:06
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ugreener

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ugreener: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml (1)

1-44: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Run make update and include downstream generated changes for this new CI config.

This PR adds a new periodic test/job definition, which is a structural ci-operator change and should regenerate downstream artifacts.

As per coding guidelines: “After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update”. Based on learnings, env-only/commands-only edits are exceptions, but this change introduces a new test/job structure.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml`
around lines 1 - 44, This change adds a new periodic test "e2e-far-weekly-aws"
(workflow "ipi-aws") under ci-operator config but did not regenerate downstream
artifacts; run the repository's generation step (execute "make update") to
regenerate downstream CI artifacts for the new test, review the produced files
for the new job/test entries, add and commit those generated files alongside
this CI config change, and push the updated commit so downstream configs align
with the new test definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml`:
- Around line 1-44: This change adds a new periodic test "e2e-far-weekly-aws"
(workflow "ipi-aws") under ci-operator config but did not regenerate downstream
artifacts; run the repository's generation step (execute "make update") to
regenerate downstream CI artifacts for the new test, review the produced files
for the new job/test entries, add and commit those generated files alongside
this CI config change, and push the updated commit so downstream configs align
with the new test definition.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4f02a31f-459a-43ae-bd0d-61b3c55aa217

📥 Commits

Reviewing files that changed from the base of the PR and between 59c0bba and c838c59.

📒 Files selected for processing (1)
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@ugreener: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config c838c59 link true /test ci-operator-config
ci/prow/generated-config c838c59 link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant