Skip to content

chore: migrate .config.prowgen to ci-operator#79341

Open
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:move-acm-config
Open

chore: migrate .config.prowgen to ci-operator#79341
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:move-acm-config

Conversation

@Prucek
Copy link
Copy Markdown
Member

@Prucek Prucek commented May 15, 2026

Summary

  • Migrate last .config.prowgen file to ci-operator config
  • Consolidate configuration management across the codebase

🤖 Generated with Claude Code

Migration of ACM Config CI Configuration

This PR migrates the last remaining .config.prowgen file for the stolostron/acm-config repository to ci-operator configuration, consolidating configuration management.

What's Changing

The CI configuration for the ACM Config repository is being moved from a separate .config.prowgen file to the main ci-operator YAML configuration file. Specifically:

  • Removed: The .config.prowgen file which contained visibility settings (expose: true and private: true)
  • Added: A new prowgen block in the main ci-operator configuration (stolostron-acm-config-main.yaml) containing the same visibility settings

Practical Impact

This consolidates the CI configuration for the ACM Config repository into a single YAML file, eliminating the need for a separate configuration file. The prowgen job generation settings (controlling whether jobs are exposed publicly and marked as private) are preserved in the new location. This is part of a larger effort to deprecate the legacy .config.prowgen format across the OpenShift CI infrastructure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: aa28d2a2-ceda-41e8-bfb2-bb42163da5c8

📥 Commits

Reviewing files that changed from the base of the PR and between d59cfdc and 08df55d.

📒 Files selected for processing (2)
  • ci-operator/config/stolostron/acm-config/.config.prowgen
  • ci-operator/config/stolostron/acm-config/stolostron-acm-config-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/stolostron/acm-config/.config.prowgen

Walkthrough

Prowgen configuration settings (expose and private flags) are consolidated from a separate .config.prowgen file into the main stolostron-acm-config-main.yaml configuration, centralizing Prow generation behavior settings in one place.

Changes

Configuration Consolidation

Layer / File(s) Summary
Move prowgen settings to main configuration
ci-operator/config/stolostron/acm-config/.config.prowgen, ci-operator/config/stolostron/acm-config/stolostron-acm-config-main.yaml
Prowgen visibility settings are removed from .config.prowgen and added to the main YAML configuration file with expose: true and private: true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: migrating .config.prowgen configuration entries to the ci-operator configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only YAML configuration files with no Ginkgo tests. The "Stable and Deterministic Test Names" check is not applicable to configuration file migrations.
Test Structure And Quality ✅ Passed This PR contains only configuration file changes (YAML). The custom check is for Ginkgo test code quality, which is not applicable since no test files are present.
Microshift Test Compatibility ✅ Passed This PR contains only configuration file changes (removing .config.prowgen and updating YAML CI config). No new Ginkgo e2e tests are added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only CI configuration file changes (migrating .config.prowgen to ci-operator config). No Ginkgo e2e tests added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Check not applicable. PR only modifies CI configuration files (.config.prowgen and YAML config), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration file changes. OTE Binary Stdout Contract check applies only to process-level source code. No source code files modified in this PR.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only CI operator configuration files, not Ginkgo e2e tests. The check applies only when new Ginkgo tests are added. Not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dislbenn and gparvin May 15, 2026 11:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-stolostron-acm-config-main-fast-forward N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant