-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add deferred Orion summary report step for consolidated regression reporting #75575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 5 commits into
openshift:main
from
mohit-sheth:orion-summary-step
Apr 10, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
52e53b4
Add deferred Orion summary report step for consolidated regression re…
mohit-sheth 9855989
Fix shellcheck warnings and ci-operator issues
mohit-sheth e171f6c
Simplify deferred JSON copy and save report output to artifacts
mohit-sheth ee9ef7e
Fetch deferred orion JSONs from GCS instead of SHARED_DIR
mohit-sheth 4212413
Remove ovn-kubernetes RUN_ORION changes for separate PR
mohit-sheth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - perfscale-ocp-approvers | ||
| reviewers: | ||
| - perfscale-ocp-reviewers |
83 changes: 83 additions & 0 deletions
83
ci-operator/step-registry/openshift-qe/orion/report/openshift-qe-orion-report-commands.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| #!/bin/bash | ||
| set -x | ||
| set -euo pipefail | ||
|
|
||
| if [ "${RUN_ORION}" == "false" ]; then | ||
| echo "RUN_ORION is false, skipping report." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Fetch deferred JSON results from previous steps' GCS artifacts | ||
| GCS_BUCKET="gs://test-platform-results" | ||
| GCS_BASE="" | ||
|
|
||
| case "${JOB_TYPE:-}" in | ||
| presubmit) | ||
| if [[ -n "${REPO_OWNER:-}" && -n "${REPO_NAME:-}" && -n "${PULL_NUMBER:-}" && -n "${JOB_NAME:-}" && -n "${BUILD_ID:-}" ]]; then | ||
| GCS_BASE="${GCS_BUCKET}/pr-logs/pull/${REPO_OWNER}_${REPO_NAME}/${PULL_NUMBER}/${JOB_NAME}/${BUILD_ID}/artifacts" | ||
| fi | ||
| ;; | ||
| periodic) | ||
| if [[ -n "${JOB_NAME:-}" && -n "${BUILD_ID:-}" ]]; then | ||
| GCS_BASE="${GCS_BUCKET}/logs/${JOB_NAME}/${BUILD_ID}/artifacts" | ||
| fi | ||
| ;; | ||
| esac | ||
|
|
||
| if [[ -z "$GCS_BASE" ]]; then | ||
| echo "Could not determine GCS artifacts path. Skipping report." | ||
| exit 0 | ||
| fi | ||
|
|
||
| echo "Fetching deferred orion JSONs from GCS: ${GCS_BASE}" | ||
| mkdir -p /tmp/orion-jsons | ||
| gsutil -m cp "${GCS_BASE}/*/openshift-qe-orion-*/artifacts/junit_*.json" /tmp/orion-jsons/ 2>/dev/null || true | ||
|
|
||
| shopt -s nullglob | ||
| json_files=(/tmp/orion-jsons/junit*.json) | ||
| shopt -u nullglob | ||
|
|
||
| if [ ${#json_files[@]} -eq 0 ]; then | ||
| echo "No deferred orion JSON results found in GCS." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Copy JSONs to ARTIFACT_DIR for archival | ||
| cp "${json_files[@]}" "${ARTIFACT_DIR}/" 2>/dev/null || true | ||
|
|
||
| # Set up Python environment and install orion | ||
| python --version | ||
| pushd /tmp | ||
| python -m virtualenv ./venv_report | ||
| source ./venv_report/bin/activate | ||
|
|
||
| if [[ $TAG == "latest" ]]; then | ||
| LATEST_TAG=$(curl -s "https://api.github.com/repos/cloud-bulldozer/orion/releases/latest" | jq -r '.tag_name') | ||
| else | ||
| LATEST_TAG=$TAG | ||
| fi | ||
| git clone --branch "$LATEST_TAG" "$ORION_REPO" --depth 1 | ||
| pushd orion | ||
| pip install -r requirements.txt | ||
| pip install . | ||
| popd && popd | ||
|
|
||
| # Build comma-separated file list for orion --report | ||
| json_file_list="" | ||
| for f in "${json_files[@]}"; do | ||
| json_file_list="${json_file_list:+${json_file_list},}${f}" | ||
| done | ||
|
|
||
| # Run orion report on all deferred JSONs | ||
| # orion --report exits 2 if regressions found, 0 otherwise | ||
| set +e | ||
| orion --report "$json_file_list" | tee "${ARTIFACT_DIR}/orion-report-summary.txt" | ||
| report_exit=$? | ||
| set -e | ||
|
|
||
| if [ "$report_exit" -eq 2 ]; then | ||
| echo "Orion report detected regressions." | ||
| exit 1 | ||
| fi | ||
|
|
||
| exit "$report_exit" |
11 changes: 11 additions & 0 deletions
11
...rator/step-registry/openshift-qe/orion/report/openshift-qe-orion-report-ref.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "path": "openshift-qe/orion/report/openshift-qe-orion-report-ref.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "perfscale-ocp-approvers" | ||
| ], | ||
| "reviewers": [ | ||
| "perfscale-ocp-reviewers" | ||
| ] | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
ci-operator/step-registry/openshift-qe/orion/report/openshift-qe-orion-report-ref.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| ref: | ||
| as: openshift-qe-orion-report | ||
| from_image: | ||
| namespace: ci | ||
| name: ocp-qe-perfscale-ci | ||
| tag: latest | ||
| env: | ||
| - name: ORION_REPO | ||
| default: "https://github.com/cloud-bulldozer/orion.git" | ||
| documentation: | ||
| Orion github repository to clone for report generation. | ||
| - name: TAG | ||
| default: "latest" | ||
| documentation: | ||
| Orion version/tag to clone. | ||
| - name: RUN_ORION | ||
| default: "false" | ||
| documentation: | ||
| When false, the report step is skipped. Set to deferred at test level to enable deferred failure reporting. | ||
| commands: openshift-qe-orion-report-commands.sh | ||
| timeout: 30m | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 100Mi | ||
| documentation: >- | ||
| Aggregates deferred orion regression results from SHARED_DIR using | ||
| orion --report to produce a consolidated regression report. Must be | ||
| used as the last step in an orion chain when RUN_ORION is set to deferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.