maistra builder: push to correct registry#75562
maistra builder: push to correct registry#75562openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
| env: | ||
| - name: MAISTRA_NAMESPACE | ||
| - name: MAISTRA_SC_POD | ||
| - name: HUB |
There was a problem hiding this comment.
You must give it a value. I think HUB is only used in postsubmit tasks, so no need to set it in other places I think. Also I'm not sure if changing other bits in this PR is the right way.
There was a problem hiding this comment.
I defined the value at line 803. Isn't that the correct way?
Also I'm not sure if changing other bits in this PR is the right way.
Those are just mismatched versions of ossm.
There was a problem hiding this comment.
I think HUB is only used in postsubmit tasks, so no need to set it in other places I think.
That is correct. I added the HUB env var to postsubmit task of other OSSM versions as well.
Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
lgtm |
|
/pj-rehearse ack |
|
@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkralik3, zmiklank The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test core-valid |
1 similar comment
|
/test core-valid |
|
@zmiklank: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* maistra builder: push to correct registry Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> * run 'make update' Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> --------- Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
* maistra builder: push to correct registry Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> * run 'make update' Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> --------- Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
* maistra builder: push to correct registry Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> * run 'make update' Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com> --------- Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
No description provided.