Skip to content

maistra builder: push to correct registry#75562

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
zmiklank:maistra_builder_quay.io
Mar 3, 2026
Merged

maistra builder: push to correct registry#75562
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
zmiklank:maistra_builder_quay.io

Conversation

@zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Mar 2, 2026

No description provided.

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
env:
- name: MAISTRA_NAMESPACE
- name: MAISTRA_SC_POD
- name: HUB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must give it a value. I think HUB is only used in postsubmit tasks, so no need to set it in other places I think. Also I'm not sure if changing other bits in this PR is the right way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defined the value at line 803. Isn't that the correct way?

Also I'm not sure if changing other bits in this PR is the right way.

Those are just mismatched versions of ossm.

Copy link
Contributor Author

@zmiklank zmiklank Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think HUB is only used in postsubmit tasks, so no need to set it in other places I think.

That is correct. I added the HUB env var to postsubmit task of other OSSM versions as well.

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@zmiklank: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-test-infra-main-test-infra-build-containers-3-2 maistra/test-infra presubmit Ci-operator config changed
pull-ci-maistra-test-infra-main-test-infra-build-containers-3-3 maistra/test-infra presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mkralik3
Copy link
Contributor

mkralik3 commented Mar 3, 2026

lgtm

@mkralik3
Copy link
Contributor

mkralik3 commented Mar 3, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkralik3, zmiklank

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmiklank
Copy link
Contributor Author

zmiklank commented Mar 3, 2026

/test core-valid

1 similar comment
@liangxia
Copy link
Member

liangxia commented Mar 3, 2026

/test core-valid

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@zmiklank: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1aa30a5 into openshift:main Mar 3, 2026
13 checks passed
zhfeng pushed a commit to zhfeng/release that referenced this pull request Mar 4, 2026
* maistra builder: push to correct registry

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

* run 'make update'

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

---------

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
coleenquadros pushed a commit to coleenquadros/release that referenced this pull request Mar 5, 2026
* maistra builder: push to correct registry

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

* run 'make update'

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

---------

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
rrasouli pushed a commit to rrasouli/release that referenced this pull request Mar 5, 2026
* maistra builder: push to correct registry

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

* run 'make update'

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

---------

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants