Validate HostedCluster conditions for Agent

[mgencur]

Add step-registry component to verify HostedCluster status conditions in Agent platform deployments. Validates conditions like Available, ValidConfiguration, and SupportedHostedCluster before tests run.

Integrated into multiple hypershift-mce-agent test chains.

This mimics the ValidateHostedClusterConditions from openshift/hypershift. Hovewer, it only checks conditions that are general for all platforms or specific for Agent. Checks for other platforms (AWS, Kubevirt, etc.) are excluded because this step is specific for Agent.

Covers also ControlPlaneConnectionAvailable and DataPlaneConnectionAvailable from https://issues.redhat.com/browse/CNTRLPLANE-2203

[openshift-ci-robot]

@mgencur: This pull request references CNTRLPLANE-2203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

Add comprehensive validation function that checks 20+ HostedCluster conditions with version-aware and context-specific assertions. Supports worker/worker-less clusters, managed/unmanaged etcd, and OpenShift version-specific conditions.

Covers also ControlPlaneConnectionAvailable and DataPlaneConnectionAvailable from https://issues.redhat.com/browse/CNTRLPLANE-2203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@mgencur: This pull request references CNTRLPLANE-2203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

Add step-registry component to verify HostedCluster status conditions in Agent platform deployments. Validates conditions like Available, ValidConfiguration, and SupportedHostedCluster before tests run.

Integrated into multiple hypershift-mce-agent test chains.

Covers also ControlPlaneConnectionAvailable and DataPlaneConnectionAvailable from https://issues.redhat.com/browse/CNTRLPLANE-2203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mgencur: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Add step-registry component to verify HostedCluster status conditions in Agent platform deployments. Validates conditions like Available, ValidConfiguration, and SupportedHostedCluster before tests run.

Integrated into multiple hypershift-mce-agent test chains.

Covers also ControlPlaneConnectionAvailable and DataPlaneConnectionAvailable from https://issues.redhat.com/browse/CNTRLPLANE-2203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jparrill]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS [jparrill]
• ci-operator/step-registry/hypershift/agent/OWNERS [jparrill]
• ci-operator/step-registry/hypershift/mce/agent/OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zhfeng]

Hi @mgencur ,

When I invesigate

• Fix squid proxy by adding hosted cluster API NodePort to allowed_ssl_ports #75256

The check condition for PlatformCredentialsFound is always failed on 4.16. So I wonder if this condition is not avaliable on 4.16. The following output is analysted by AI to find the different between the 4.16 codebase and others.

In HyperShift's hostedcluster_controller.go, after ReconcileCredentials succeeds, the code to set the condition to
True differs between versions:

release-4.16:

  if meta.IsStatusConditionFalse(..., "PlatformCredentialsFound") {
      // set to True
  }

release-4.17+:

  if !meta.IsStatusConditionTrue(..., "PlatformCredentialsFound") {
      // set to True
  }

The difference:

• IsStatusConditionFalse → returns true only when the condition exists AND is False
• !IsStatusConditionTrue → returns true when the condition doesn't exist OR is False

On a fresh HostedCluster where credentials never failed, the condition was never created. On 4.16, IsStatusConditionFalse sees "condition doesn't exist" and returns false, so it never sets it to True. The condition simply never appears.

On 4.17+, !IsStatusConditionTrue sees "condition doesn't exist" and returns true, so it properly sets it to True on the first successful reconciliation.

cc @jparrill

[mgencur]

@zhfeng Yeah. Looks like this was a bug fixed in 4.17. We can exclude this condition for 4.16 and older.

[mgencur]

@zhfeng Sent #75544