-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-2202: add new exceptions + fail if uncaught default sa usage is detected #30685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CNTRLPLANE-2202: add new exceptions + fail if uncaught default sa usage is detected #30685
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@ehearne-redhat: This pull request references CNTRLPLANE-2202 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehearne-redhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
|
/test e2e-aws-csi |
|
/test e2e-vsphere-ovn-upi |
|
/test e2e-aws-ovn-microshift-serial |
|
/retest |
|
@ehearne-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 8dc1218
|
This PR is a draft PR until we are certain no new default service account usage has been detected
This PR adds new exceptions previously not caught. It also ensures default service account usage test fail if uncaught exception is found, such as when a new deployment is added to a PR, which does not have an associated service account.
This should hopefully encourage service account usage to be thought of/enforce it when creating new deployments/daemonsets, etc.