Fix MetalLB procedure gaps found by live cluster verification#111440
Open
kquinn1204 wants to merge 1 commit intoopenshift:mainfrom
Open
Fix MetalLB procedure gaps found by live cluster verification#111440kquinn1204 wants to merge 1 commit intoopenshift:mainfrom
kquinn1204 wants to merge 1 commit intoopenshift:mainfrom
Conversation
Tested all four MetalLB procedures on a live OCP 4.21 cluster and fixed 19 documentation gaps including magic steps, missing wait commands, unusable example IPs, and an entirely abstract service configuration procedure. Key changes: - Convert save-to-file patterns to inline cat << EOF | oc apply - Add wait step before MetalLB controller verification - Replace unusable 4.4.4.0/24 with RFC 5737 documentation range - Add concrete deployment + LoadBalancer service example - Add missing prerequisites and verification sections - Fix typos (metdata, CSV version prefix, pool name mismatch) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
size/L
| $ oc apply -f ipaddresspool.yaml | ||
| EOF | ||
| ---- | ||
| <1> Replace the address range with addresses that are appropriate for your network. |
Collaborator
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| protocol: TCP | ||
| EOF | ||
| ---- | ||
| <1> The `metallb.io/address-pool` annotation is required when the address pool has `autoAssign` set to `false`. Replace `doc-example-l2` with the name of your address pool. |
Collaborator
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
|
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cat << EOF | oc apply -f -for consistency and automation4.4.4.0/24example IP range with RFC 5737 documentation range (203.0.113.200-203.0.113.210)Files changed
modules/nw-metallb-installing-operator-cli.adocmodules/nw-metallb-operator-initial-config.adococ waitstep, fixmetdatatypomodules/nw-metallb-configure-l2-advertisement.adocmodules/nw-metallb-configure-svc.adocTest plan
curlreturned "Hello OpenShift!")🤖 Generated with Claude Code