CNV#82024: formula correction#111405
Open
ousleyp wants to merge 1 commit intoopenshift:mainfrom
Open
Conversation
openshift-ci
Bot
added
the
size/XS
|
@ousleyp: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
germanovm
reviewed
May 7, 2026
| ** The PVC must be large enough to contain the memory dump. | ||
| + | ||
| The formula for calculating the PVC size is `(VMMemorySize + 100Mi) * FileSystemOverhead`, where `100Mi` is the memory dump overhead, and `FileSystemOverhead` is defined in the `HCO` object. | ||
| The formula for calculating the PVC size is `(VMMemorySize + 100Mi) * (1 + FileSystemOverhead)`, where `100Mi` is the memory dump overhead, and `FileSystemOverhead` is defined in the `HCO` object. |
There was a problem hiding this comment.
Correct, so the VM memory size is multiplied by (1+0.xxx) and not by 0.xxx.
Member
Author
|
Hey @stu-gott , are you around to QE this fix? Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s): likely all supported versions
Issue: CNV-82024
Link to docs preview: https://111405--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/support/virt-collecting-virt-data.html
QE review:
Additional information: