Skip to content

[CNV-83214] Add IBM Spyre support#110834

Closed
SNiemann15 wants to merge 20 commits intoopenshift:mainfrom
SNiemann15:ocpvirt_ibmz_spyre
Closed

[CNV-83214] Add IBM Spyre support#110834
SNiemann15 wants to merge 20 commits intoopenshift:mainfrom
SNiemann15:ocpvirt_ibmz_spyre

Conversation

@SNiemann15
Copy link
Copy Markdown
Contributor

@SNiemann15 SNiemann15 commented Apr 27, 2026 •
edited
Loading

Version(s):

Issue: https://redhat.atlassian.net/browse/CNV-83214

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: In addition to the Spyre changes, I removed the Intel QAT mentions see comment in the Jira issue.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Apr 27, 2026 •
edited
Loading

🤖 Fri May 08 07:13:01 - Prow CI generated the docs preview:

https://110834--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-configuring-pci-passthrough.html
https://110834--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-configuring-virtual-gpus.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Apr 27, 2026
View reviewed changes
Comment thread modules/virt-binding-devices-vfio-driver.adoc
@SNiemann15
Copy link
Copy Markdown
Contributor Author

SNiemann15 commented Apr 28, 2026

/retest

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_spyre branch 2 times, most recently from adc4167 to 8fe8165 Compare April 29, 2026 13:58
@SNiemann15 SNiemann15 changed the title [CNV-83214] Add IBM Spyre support WIP [CNV-83214] Add IBM Spyre support Apr 29, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2026
SNiemann15
SNiemann15 commented Apr 29, 2026
View reviewed changes
Comment thread modules/virt-binding-devices-vfio-driver.adoc Outdated
ousleyp
ousleyp reviewed Apr 29, 2026
View reviewed changes
Comment thread virt/managing_vms/advanced_vm_management/virt-configuring-pci-passthrough.adoc Outdated
Comment on lines +69 to +73
[role="_additional-resources"]
.Additional resources

* link:https://www.ibm.com/docs/en/systems-hardware/linuxone/9175-ML1?topic=library-spyre-accelerator-users-guide[{ibm-name} Spyre Accelerator User's Guide]

Copy link
Copy Markdown
Member

@ousleyp ousleyp Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of DITA migration prep, we are no longer allowed to do this type of module-level additional resources section in the middle of an assembly. All links need to be moved to an assembly-level (== Additional resources) section at the end of the assembly in the main and 4.20+ branches. (We are gradually working on this as part of our migration effort, so you will likely see some areas where it hasn't been fixed yet.)

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_spyre branch 3 times, most recently from 91fe68b to 077b3d7 Compare May 7, 2026 13:59
@SNiemann15 SNiemann15 changed the title WIP [CNV-83214] Add IBM Spyre support [CNV-83214] Add IBM Spyre support May 7, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2026
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_spyre branch from 64a4202 to ab8e973 Compare May 7, 2026 14:46
@vamsikrishna-siddu
Copy link
Copy Markdown

vamsikrishna-siddu commented May 8, 2026

Thanks @SNiemann15
/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 8, 2026

@vamsikrishna-siddu: changing LGTM is restricted to collaborators

Details

In response to this:

Thanks @SNiemann15
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_spyre branch from ab8e973 to 3ad5a8a Compare May 8, 2026 06:48
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_spyre branch from 3ad5a8a to 2729527 Compare May 8, 2026 07:02
@openshift-ci openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 8, 2026

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SNiemann15 SNiemann15 closed this May 8, 2026
@SNiemann15
Copy link
Copy Markdown
Contributor Author

SNiemann15 commented May 8, 2026

Small typo when squashing caused a big mess 😭 I gave up and created a new PR #111420

@SNiemann15 SNiemann15 deleted the ocpvirt_ibmz_spyre branch May 8, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ousleyp ousleyp ousleyp left review comments

+1 more reviewer

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.