OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page.#15928
Conversation
📝 WalkthroughWalkthroughThis change modifies the workload table component to correctly handle replica count display for DaemonSet resources. Previously, the component used uniform property access patterns for all workload types. The update introduces conditional logic that distinguishes between DaemonSets and other workload kinds, using 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
@cajieh: This pull request references Jira Issue OCPBUGS-72260, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| // DaemonSets use different status fields than Deployments | ||
| const isDaemonSet = kind?.includes('DaemonSet'); | ||
| const statusReplicas = kind?.includes('DaemonSet') |
There was a problem hiding this comment.
Nit
| const statusReplicas = kind?.includes('DaemonSet') | |
| const statusReplicas = isDaemonSet |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@cajieh: This pull request references Jira Issue OCPBUGS-72260, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified |
|
@cajieh: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @yapei |
|
@cajieh: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cajieh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@cajieh: Jira Issue OCPBUGS-72260: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
1 similar comment
|
/cherry-pick release-4.21 |
|
@cajieh: new pull request created: #15953 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |


Before:
After:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.