CORS-4209: ensure NodeIPFamilies field is kept as-is after transforming#426
Conversation
|
@tthvo: This pull request references CORS-4209 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/jira refresh |
|
@tthvo: This pull request references CORS-4209 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @sadasu |
|
/assign @nrb |
|
Running the unit tests locally, I'm not able to get it to fail, so not sure what's going on with CI. I think this is all reasonable, just need to remove a stray comment. |
|
/verified by unit test and testwith openshift/installer#9930 |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Local unit test passed quite consistently for me too 👀 I guess the test is flaky? It passed now on CI: ci/prow/unit 😁 |
Yeah, I wasn't able to reproduce these failures, either. Looks like right now quay might be having issues. |
|
/retest-required Let's see if things are back to normal 👀 |
|
/test e2e-aws-ovn |
|
/retest |
|
/lgtm |
|
/lgtm |
openshift-ci-robot
removed
the
verified
In dual-stack environment, the CCM expects NodeIPFamilies to be in the format: NodeIPFamilies=ipv4 NodeIPFamilies=ipv6 However, iniv1 is serializing go slices as comma-separated list, for example: NodeIPFamilies=ipv4,ipv6 This commit ensures the original NodeIPFamilies field is kept as-is after transforming.
|
/verified by @tthvo (with installer PR#9930) |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test vet |
|
@tthvo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
In dual-stack environment, the CCM AWS provider expects
NodeIPFamilies(kubernetes/cloud-provider-aws#638) to be in the format:However,
iniv1is serializing go slices as comma-separated list, for example:NodeIPFamilies=ipv4,ipv6This commit ensures the original NodeIPFamilies field is kept as-is after transforming.