Skip to content

HYPERFLEET-1143 - chore: Remove kind from list schemas #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 4 commits into from
Jun 15, 2026
Merged

HYPERFLEET-1143 - chore: Remove kind from list schemas #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc3cba3
HYPERFLEET-1143 - chore: Remove kind from list schemas
tirthct Jun 4, 2026
0bbcfb5
HYPERFLEET-1143 - chore: Fix CI build
tirthct Jun 4, 2026
d49aa9d
HYPERFLEET-1143 - chore: merged from main
tirthct Jun 15, 2026
4fcd953
HYPERFLEET-1143 - chore: Fix merge conflicts and CHANGELOG.md
tirthct Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .spectral.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ extends: ["spectral:oas"]
overrides:
- files:
- "schemas/template/openapi.yaml#/components/schemas/BearerAuth"
- "schemas/template/openapi.yaml#/components/schemas/ForbiddenResponse"
rules:
oas3-unused-component: off
14 changes: 13 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.0.23] - 2026-06-11

@rafabene rafabene Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

nit — non-blocking suggestion

Category: Standards

This release removes kind from list schema required fields and rewrites the error model (Error → ProblemDetails), both breaking changes for consumers doing code generation. Per the commit standard, the squash merge commit should include a BREAKING CHANGE: footer. Consider adding this to the PR body so it lands in the squash commit:

BREAKING CHANGE: `kind` removed from required fields in ChannelList, ClusterList,
NodePoolList, VersionList, WifConfigList. Error schema renamed from `Error` to
`ProblemDetails` with status-specific schemas (BadRequestDetails, ConflictDetails,
NotFoundDetails, UnauthorizedDetails). Consumers must regenerate clients from
the updated spec.

@tirthct tirthct Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a footer in the PR body


### Removed

- `kind` property from `ChannelList`, `ClusterList`, `NodePoolList`, `VersionList`, and `WifConfigList` list response schemas — inherited from core spec update (HYPERFLEET-1143)

### Changed

- Error responses now use RFC 9457 `ProblemDetails` format with status-specific schemas (`BadRequestDetails`, `ConflictDetails`, `NotFoundDetails`, `UnauthorizedDetails`) — inherited from core spec update (HYPERFLEET-993)
- Pagination query parameters (`page`, `pageSize`) now enforce `minimum: 1` (HYPERFLEET-993)

## [1.0.22] - 2026-06-04

### Changed
Expand Down Expand Up @@ -75,7 +86,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- Links -->

[Unreleased]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.22...HEAD
[Unreleased]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.23...HEAD
[1.0.23]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.22...v1.0.23
[1.0.22]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.21...v1.0.22
[1.0.21]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.20...v1.0.21
[1.0.20]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec-template/compare/v1.0.19...v1.0.20
Expand Down
2 changes: 1 addition & 1 deletion main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ using OpenAPI;
*/
@service(#{ title: "HyperFleet API" })
@info(#{
version: "1.0.22",
version: "1.0.23",
contact: #{
name: "HyperFleet Team",
url: "https://github.com/openshift-hyperfleet",
Expand Down
Loading