fix(ism): change lastUpdatedTime from Integer to Long to prevent epoc…#1977
Closed
Zahanturel wants to merge 2 commits into
Closed
fix(ism): change lastUpdatedTime from Integer to Long to prevent epoc…#1977Zahanturel wants to merge 2 commits into
Zahanturel wants to merge 2 commits into
Conversation
Zahanturel
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
…h-ms overflow `last_updated_time` carries epoch-millisecond timestamps (e.g. 1700000000000). These values exceed Integer.MAX_VALUE (2147483647), causing InputCoercionException with JacksonJsonpMapper and silent negative-value corruption with JsonbJsonpMapper. Fixes: opensearch-project#1898 Signed-off-by: Zahan Turel <turelzahan10@gmail.com>
Signed-off-by: Zahan Turel <turelzahan10@gmail.com>
Zahanturel
force-pushed
the
fix/ism-last-updated-time-long-overflow
branch
from
9d3cf40 to
417db40
Compare
reta
requested changes
May 9, 2026
Collaborator
reta
left a comment
reta
left a comment
There was a problem hiding this comment.
@Zahanturel thanks for the change, these files are generated, please submit the change to specification instead - https://github.com/opensearch-project/openSearch-api-specification
Author
|
Thanks for the redirect. Will submit the fix to the API specification repo instead at opensearch-project/opensearch-api-specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change achieve?
last_updated_timeinPolicyandIsmTemplatecarries epoch-millisecond timestamps. These values (e.g.1700000000000) exceedInteger.MAX_VALUE(2147483647), causingInputCoercionExceptionwithJacksonJsonpMapperand silent negative-value corruption withJsonbJsonpMapper.Changes
format: int64in the OpenAPI spec (the code generation source of truth) and updates the generated Java models accordingly. Verified againstTypeMapper.javaand the Mustache templates that the generated output is identical to what./gradlew :java-codegen:runwould produce.Issues Resolved
Fixes #1898.