Add UpgradePluginsForJava25 for surefire, failsafe, compiler, and byte-buddy #981
+323
−246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2026 23:34
…e-buddy
Closes moderneinc/customer-requests#1820
| .containsPattern("maven-compiler-plugin</artifactId>\\s*<version>3\\.15\\.") | ||
| .containsPattern("maven-surefire-plugin</artifactId>\\s*<version>3\\.") | ||
| .containsPattern("maven-failsafe-plugin</artifactId>\\s*<version>3\\.") | ||
| .actual()) |
Contributor
There was a problem hiding this comment.
Should byte-buddy show up in the test?
Member
Author
There was a problem hiding this comment.
Since it's just a UpgradeDependencyVersion I think we have that sufficiently covered elsewhere. Thanks for the suggestions though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UpgradePluginsForJava25recipe to upgrade Maven plugins and dependencies to Java 25 compatible versionsUpgradeToJava25recipeProblem
After migrating to Java 25, Maven plugins need to be at minimum compatible versions. The existing
UpgradeToJava25recipe handles code migrations and<release>25</release>but does not upgrade plugin versions, causing build failures.Solution
New
UpgradePluginsForJava25declarative recipe that upgrades:maven-compiler-pluginto3.15.x(3.14.1 has known Java 25 issues)maven-surefire-pluginto3.1.xmaven-failsafe-pluginto3.1.xbyte-buddyto1.17.x(ASM 9.8 for Java 25 class files)9.1(first version with Java 25 support)Follows the established pattern from
UpgradePluginsForJava17andUpgradePluginsForJava21.Test plan
Existing tests pass
New test verifying plugin version upgrades
recipes.csvregenerated and validatedFixes moderneinc/customer-requests#1819
Fixes moderneinc/customer-requests#1820