Skip to content

Add map dyslexdria#3568

Merged
evanpelle merged 10 commits intoopenfrontio:mainfrom
PatrickPlaysBadly:ADD-Map-DYSLEXDRIA
Apr 3, 2026
Merged

Add map dyslexdria#3568
evanpelle merged 10 commits intoopenfrontio:mainfrom
PatrickPlaysBadly:ADD-Map-DYSLEXDRIA

Conversation

@PatrickPlaysBadly
Copy link
Copy Markdown
Contributor

Description:

Re Add map Dyslexdria. I adjusted the rivers to make boat traffic go through main channels isntead of shortcuts. Flags adjusted. Correct thumbnail added

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Discord username

Plays Badly

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fe6ac549-5e47-4a95-8abd-64f2754c06ef

📥 Commits

Reviewing files that changed from the base of the PR and between 9263586 and 2ce5780.

📒 Files selected for processing (1)
  • map-generator/main.go
✅ Files skipped from review due to trivial changes (1)
  • map-generator/main.go

Walkthrough

Adds a new map "Dyslexdria" via JSON assets and manifest, registers it in the map generator, adds English localization, and extends the TypeScript map enum and category to include the new map.

Changes

Cohort / File(s) Summary
Map Assets & Manifest
map-generator/assets/maps/dyslexdria/info.json, resources/maps/dyslexdria/manifest.json
New JSON files providing Dyslexdria map metadata and full manifest (dimensions, land counts, nations with coordinates, flags, and names).
Map Registration
map-generator/main.go
Added dyslexdria to the maps registry, making it selectable/processable by the generator.
Localization
resources/lang/en.json
Added "dyslexdria": "Dyslexdria" entry to English localization under map.
Game Type Definition
src/core/game/Game.ts
Added GameMapType.Dyslexdria enum member and included it in mapCategories.fantasy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🗺️ A fresh map whispers on the JSON shore,
Dyslexdria's flags and names now soar,
Coordinates placed in tidy rows,
A little world the engine knows. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add map dyslexdria' directly and clearly describes the main change: adding a new map named Dyslexdria to the codebase.
Description check ✅ Passed The description is related to the changeset, providing context about map adjustments (rivers, flags, thumbnail) and noting that translations and tests were added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@map-generator/main.go`:
- Line 88: The keyed struct literal uses a lowercase field key `name` which does
not match the exported struct field `Name`; update the literal to use the exact
case `Name` (e.g., change `{name: "dyslexdria"}` to use the `Name` field) so the
keyed composite literal matches the struct's `Name` field and the code compiles.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9075480-ac5a-410b-8ac1-6a9f001f7eed

📥 Commits

Reviewing files that changed from the base of the PR and between 21c2861 and 9263586.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/dyslexdria/image.png is excluded by !**/*.png
  • resources/maps/dyslexdria/map.bin is excluded by !**/*.bin
  • resources/maps/dyslexdria/map16x.bin is excluded by !**/*.bin
  • resources/maps/dyslexdria/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (6)
  • map-generator/assets/maps/dyslexdria/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/dyslexdria/manifest.json
  • resources/maps/dyslexdria/thumbnail.webp
  • src/core/game/Game.ts

@github-project-automation github-project-automation bot moved this from Triage to Development in OpenFront Release Management Apr 3, 2026
@github-project-automation github-project-automation bot moved this from Development to Final Review in OpenFront Release Management Apr 3, 2026
@evanpelle evanpelle added this to the v31 milestone Apr 3, 2026
@evanpelle evanpelle merged commit 6467007 into openfrontio:main Apr 3, 2026
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants