Skip to content

Adds Antarctica map#3560

Open
RickD004 wants to merge 2 commits intoopenfrontio:mainfrom
RickD004:antarctica
Open

Adds Antarctica map#3560
RickD004 wants to merge 2 commits intoopenfrontio:mainfrom
RickD004:antarctica

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

@RickD004 RickD004 commented Apr 2, 2026

Description:

Re-adds and reworks the previously April Fools "Reglaciated Antarctica" as a new map, this time with proper elevation data: Map of Antarctica centered in the South Pole.

The "appeal" of this a map is that it has no green terrain. (As such it has a really low rotation number (of 2). )

This also completes the Continental map category (antarctica was the only continent out of the traditional 7 missing).

antarctica.mp4

The base map image is a composite of 2 relief maps from 2 different sources, both properly credited

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0c3ce559-a1bf-412d-80bc-5463889ec3b2

📥 Commits

Reviewing files that changed from the base of the PR and between 582b4ee and 5dbd460.

📒 Files selected for processing (1)
  • CREDITS.md
✅ Files skipped from review due to trivial changes (1)
  • CREDITS.md

Walkthrough

Adds Antarctica as a new game map: assets and manifest, map-generator registration, English label, game enum/category update, playlist weighting, and new credit entries for Polar Geospatial Center and USGS dataset.

Changes

Cohort / File(s) Summary
Core Game Type Definition
src/core/game/Game.ts
Added Antarctica to GameMapType and included it in the continental category.
Map Generation Pipeline
map-generator/main.go, map-generator/assets/maps/antarctica/info.json
Registered antarctica in maps registry and added info.json with 10 nation entries (coordinates, names, flags).
Map Configuration
resources/maps/antarctica/manifest.json
New manifest with name: "antarctica", base/variant dimensions and land-tile counts, plus 10 nation definitions.
Localization & Playlist
resources/lang/en.json, src/server/MapPlaylist.ts
Added map.antarctica translation and set playlist frequency weight Antarctica: 2.
Attribution
CREDITS.md
Inserted “Antarctica Map” credit block with Polar Geospatial Center citation (DOI/Dataverse/version), PGC Terms of Use link, USGS dataset attribution, and public-domain reference link.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer/CI
  participant Gen as Map Generator
  participant Assets as Assets (resources/..., map-generator/assets)
  participant Server as Game Server
  participant Client as Game Client

  Dev->>Gen: run build/generate (includes `antarctica`)
  Gen->>Assets: read `assets/maps/antarctica/info.json` and image
  Gen->>Assets: read `resources/maps/antarctica/manifest.json`
  Gen-->>Server: emit generated map assets/manifest
  Server->>Server: register map (`GameMapType.Antarctica`)
  Server->>Server: include in playlist (weight 2)
  Client->>Server: request map list
  Server-->>Client: return map list with Antarctica entry
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

❄️ New ice on the map, a frosty chart,
Penguins, claims, and a daring heart,
Antarctica now joins the play,
Cold winds code the world today. 🧊

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'Adds Antarctica map' directly and clearly describes the main change: introducing a new Antarctica map to the system.
Description check ✅ Passed The description is well-related to the changeset, providing context about the map's purpose, features (no green terrain, rotation number of 2), and completion of the Continental category.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CREDITS.md`:
- Line 72: Replace the agency name text in CREDITS.md where it currently reads
"U.S Geological Survey" (the line containing the link
https://earthexplorer.usgs.gov/metadata/4980/GT30ANTARCPS/) with the correctly
punctuated "U.S. Geological Survey" to ensure consistent naming across the
credits; update only the visible text portion before or inside the markdown link
so the URL remains unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2e0d64cb-77c1-4a09-8262-44bc73aae597

📥 Commits

Reviewing files that changed from the base of the PR and between b88c3a3 and 582b4ee.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/antarctica/image.png is excluded by !**/*.png
  • resources/maps/antarctica/map.bin is excluded by !**/*.bin
  • resources/maps/antarctica/map16x.bin is excluded by !**/*.bin
  • resources/maps/antarctica/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (8)
  • CREDITS.md
  • map-generator/assets/maps/antarctica/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/antarctica/manifest.json
  • resources/maps/antarctica/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

@github-project-automation github-project-automation bot moved this from Triage to Development in OpenFront Release Management Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Development to Final Review in OpenFront Release Management Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Final Review

Development

Successfully merging this pull request may close these issues.

1 participant