Improve ofxSvg#8518
Open
GitBruno wants to merge 1 commit into
Open
Conversation
Extract attribute conversion with proper arc and Catmull-Rom curve handling; add Inkscape layer and fill-rule support; fix use href and x/y placement. And preserve Inkscape layers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract attribute conversion with proper arc and Catmull-Rom curve handling; add Inkscape layer and fill-rule support; fix use href and x/y placement. And preserve Inkscape layers.
There is more work to do but this is what I needed for my ofxDXF addon.
For full SVG spec compliance we would still need gradients, filters, clipping, dashed strokes, skew, animations, etc :)
I would like support of dashed strokes but not quite sure how to go about. Any comment from you guys would be helpful regarding this.