ofVideoPlayer AVFoundation, setPosition can work with arbitrary frames.#8189
Closed
dimitre wants to merge 9 commits intoopenframeworks:masterfrom
Closed
ofVideoPlayer AVFoundation, setPosition can work with arbitrary frames.#8189dimitre wants to merge 9 commits intoopenframeworks:masterfrom
dimitre wants to merge 9 commits intoopenframeworks:masterfrom
Conversation
Contributor
|
it's great to be able to do that! however it might also be good to have the option to maintain the current (default) to retrieve only keyframes as inter-frame decode presumably takes more CPU it will change the performance of existing code. ex: video.setTolerance(ofVideoPlayer::TOLERANCE_ZERO);
video.setTolerance(ofVideoPlayer::TOLERANCE_INFINITY); // historical default |
Member
Author
|
We can optionally expose something like that if it is useful |
Member
Author
|
@ofTheo greattt news about the release! |
Member
Author
|
closes #4538 |
7 tasks
Member
Author
|
Closing this one as stalled. implemented in ofWorks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by lowering seekToTime tolerance to zero it will force the video frame to be displayed correctly.
Today if I load a video recorded with a camera, lets say Sony alpha 6500 in h264, it makes one keyframe each second.
if I'm trying to setPosition in an arbitrary position it will only display one frame per second (the keyframe)
with this change we assure it will be positioned in the correct frame even if it takes more cpu cycles to calculate (in the case of random access or backwards access).
it doesn't change anything for normal play because frame difference will be accumulating.
quick way of testing