feat: remove enterprise enrollment API imports and conditional block from enrollments/views.py#38106
Open
pwnage101 wants to merge 3 commits into
Open
feat: remove enterprise enrollment API imports and conditional block from enrollments/views.py#38106pwnage101 wants to merge 3 commits into
pwnage101 wants to merge 3 commits into
Conversation
…from enrollments/views.py ENT-11570
kiram15
force-pushed
the
pwnage101/ENT-11570
branch
2 times, most recently
from
723dc77 to
61a36f5
Compare
kiram15
force-pushed
the
pwnage101/ENT-11570
branch
from
61a36f5 to
59fabbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes those enterprise imports and the conditional block from the enrollment view, then runs the CourseEnrollmentViewStarted filter to handle the enterprise-specific enrollment logic seperately and outside of edx-platform. This is part of an ongoing initiative to leverage openedx-filters to allow enterprise to customize logic and remove it from edx-platform code.
ENT-11570
Supporting information
This is the openedx/openedx-filters#363
This is openedx/edx-enterprise#2553
And this is the corresponding https://github.com/openedx/openedx-platform/pull/38106 (in draft mode rn)
Testing instructions
Testing instructions in the openedx/edx-enterprise#2553.