Fix nil ptr panic when adding env variables to uninitialized Generator#791
Open
andreaskaris wants to merge 1 commit intoopencontainers:masterfrom
Open
Fix nil ptr panic when adding env variables to uninitialized Generator#791andreaskaris wants to merge 1 commit intoopencontainers:masterfrom
andreaskaris wants to merge 1 commit intoopencontainers:masterfrom
Conversation
When calling AddProcessEnv on a Generator instance that was created
using zero-value initialization (Generator{}) rather than through
New(), the envMap field would be nil. This caused a panic when
attempting to write to the map in the addEnv helper function.
This commit adds a nil check before writing to the envMap in addEnv. If
the map is uninitialized, it creates a new empty map before proceeding
with the map insertion operation.
A new test case has been added to TestEnvCaching that validates this
scenario by creating a Generator using zero-value initialization and
verifying that AddProcessEnv works correctly without panicking.
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling AddProcessEnv on a Generator instance that was created using zero-value initialization (Generator{}) rather than through New(), the envMap field would be nil. This caused a panic when attempting to write to the map in the addEnv helper function.
This commit adds a nil check before writing to the envMap in addEnv. If the map is uninitialized, it creates a new empty map before proceeding with the map insertion operation.
A new test case has been added to TestEnvCaching that validates this scenario by creating a Generator using zero-value initialization and verifying that AddProcessEnv works correctly without panicking.
Fixes #790