Merged
Conversation
There is no need to compress when building Web since the OpenCloud Web server already does this on the fly when serving the assets.
This plugin doesn't seem to be used by any of us, hence removes it.
We only used this lib to feed data from `vite.config.ts` into the `index.html` file, which can be done with basic vite functionality. Hence removes this dependency in favor of that.
JammingBen
force-pushed
the
chore/vite-8
branch
from
e069bb1 to
1eee080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vite to vite 8.
This is a major jump, it uses rolldown and osx tooling under the hood, giving us build times of ~3-4 seconds. For more details, I recommend reading https://vite.dev/blog/announcing-vite8.
There are few noteworthy changes in this PR, it's best reviewed by commits.
rollup-plugin-vite. There is no need to compress when building Web since the OpenCloud Web server already does this on the fly when serving the assets.rollup-plugin-visualizer. This plugin doesn't seem to be used by any of us.vite-plugin-environment. We can use basic vite functionality instead.ejs. We can use basic vite functionality instead.design-systemandweb-pkg, (correctly) resulting in a lot of build errors.tailwind.cssfile comes before any CSS needed some tweaking, hence the new vite plugins in cee8ced.Benchmark
Running
pnpm build: