Skip to content

fix(openapi-typescript-helpers): preserve tuple types in Readable/Writable #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panwauu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(openapi-typescript-helpers): preserve tuple types in Readable/Writable #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5f89e
fix(openapi-typescript-helpers): preserve tuple types in Readable/Wri…
panwauu Mar 12, 2026
ad696ac
Add changeset
panwauu Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wide-pianos-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"openapi-typescript-helpers": patch
---

Preserve tuple types in Readable<T> and Writable<T> by using mapped type instead of (infer E)[] pattern
8 changes: 4 additions & 4 deletions packages/openapi-typescript-helpers/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ export type Readable<T> =
? never
: T extends $Read<infer U>
? Readable<U>
: T extends (infer E)[]
? Readable<E>[]
: T extends readonly any[]
? { [K in keyof T]: Readable<T[K]> }
: T extends object
Copy link
Contributor

@gzm0 gzm0 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: T extends object
: T extends object | readonly any[]

Would that work as well? Then we could have one less branch (same below).

IIUC the mapped type for object "just" recursively resolved $Read / $Write in keys, that behavior doesn't bother us.

? { [K in keyof T as NonNullable<T[K]> extends $Write<any> ? never : K]: Readable<T[K]> }
: T;
Expand All @@ -238,8 +238,8 @@ export type Writable<T> =
? never
: T extends $Write<infer U>
? Writable<U>
: T extends (infer E)[]
? Writable<E>[]
: T extends readonly any[]
? { [K in keyof T]: Writable<T[K]> }
: T extends object
? { [K in keyof T as NonNullable<T[K]> extends $Read<any> ? never : K]: Writable<T[K]> } & {
[K in keyof T as NonNullable<T[K]> extends $Read<any> ? K : never]?: never;
Expand Down
Loading