Skip to content

fix(openapi-fetch): omit serializing for already serialized data#2556

Merged
drwpow merged 4 commits intoopenapi-ts:mainfrom
justAnArthur:fix-body-serializing
Feb 8, 2026
Merged

fix(openapi-fetch): omit serializing for already serialized data#2556
drwpow merged 4 commits intoopenapi-ts:mainfrom
justAnArthur:fix-body-serializing

Conversation

@justAnArthur
Copy link
Contributor

Changes

New changes makes omitting serializing for already serialized data, such as string, primary fixing issue with sending string as body

How to Review

Take a look at the issue: #2555 and on updated code and test.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@justAnArthur justAnArthur requested a review from a team as a code owner December 23, 2025 13:21
@justAnArthur justAnArthur requested a review from gzm0 December 23, 2025 13:21
@netlify
Copy link

netlify bot commented Dec 23, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d8424bb

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: d8424bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
openapi-fetch Patch
openapi-react-query Patch
swr-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@drwpow drwpow merged commit 36c0fb8 into openapi-ts:main Feb 8, 2026
2 of 7 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Feb 8, 2026
drwpow added a commit that referenced this pull request Feb 8, 2026
@drwpow drwpow mentioned this pull request Feb 8, 2026
@drwpow
Copy link
Contributor

drwpow commented Feb 8, 2026

Apologies, I am onboard with this change but the tests were actually failing. I had thought the CI failures were unrelated, caused by something else in CI was failing. But you actually introduced breaking behavior in your change.

Please feel free to take another shot at it, off of latest main. The tests should pass this time 🙂

drwpow added a commit that referenced this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants