fix(helpers): handle any type in RequiredKeysOf#2526
Open
jtomaszewski wants to merge 1 commit intoopenapi-ts:mainfrom
Open
fix(helpers): handle any type in RequiredKeysOf#2526jtomaszewski wants to merge 1 commit intoopenapi-ts:mainfrom
jtomaszewski wants to merge 1 commit intoopenapi-ts:mainfrom
Conversation
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
Use standard TypeScript pattern `0 extends 1 & T` to detect `any` type instead of broken `extends any` check. Also fix type issue in openapi-react-query useInfiniteQuery that was exposed by this change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
94659ee to
db4e2ec
Compare
Author
|
FYI I've added some tests and fixed all CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
createClient<any>()with placeholder or fallback OpenAPI types, TypeScript incorrectly requires the second parameter in API calls:This is problematic in scenarios where:
Root Cause
The
RequiredKeysOftype helper doesn't properly handle theanytype. WhenRequiredKeysOfHelper<T>evaluates toany, the current implementation doesn't recognize it as "no required keys", causing TypeScript to treat parameters as required.Solution
Add an additional conditional check in
RequiredKeysOf:This ensures that when the type parameter is
any,RequiredKeysOfcorrectly returnsnever, indicating no required keys. This makes the second parameter optional in API calls.Impact
createClient<any>()Relates to #1778