fix(openapi-react-query): mutation results type #2519
Merged
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: bec703f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
sacha-c
force-pushed
the
fix-mutatation-results-types
branch
from
89090ce to
ffc9e6d
Compare
Contributor
Author
|
Tests fail due to a refactor in Redocly's test folder structure (unrelated to this PR's change), I've opened a separate PR to address that here #2522 |
sacha-c
force-pushed
the
fix-mutatation-results-types
branch
from
282876f to
ded751e
Compare
|
@htunnicliff could you please merge this PR? 🙏🏼 |
Contributor
|
Thanks for adding! Could you please add a changeset (see comment)? |
sacha-c
force-pushed
the
fix-mutatation-results-types
branch
from
ded751e to
bec703f
Compare
Contributor
Author
Thanks for checking this PR! I've updated the branch & added the changset 👍 |
drwpow
approved these changes
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds proper types to the useMutation's onMutateResults fields which are used in
onSettled,onError& return object of this hook.The open issue regarding this bug: #2518
I ended up digging further & this seems to fix it, but looking forward for a second pair of eyes to check that my fix is correct 🙂
Here I moved the
Optionstype definition from the generic parameters to the actualoptionsparameter themselves, thus not setting theUseMutationOptions'sTOnMutateResultto the defaultunknown.How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)